On Mon, Nov 09, 2020 at 10:49:32PM +0530, Vidya Sagar wrote: > If the absence of CLKREQ# signal is indicated by the absence of > "supports-clkreq" in the device-tree node, current driver is disabling > the advertisement of ASPM-L1 Sub-States *before* the ASPM-L1 Sub-States > offset is correctly initialized. Since default value of the ASPM-L1SS > offset is zero, this is causing the Vendor-ID wrongly programmed to 0x10d2 > instead of Nvidia's 0x10de thereby the quirks applicable for Tegra194 are > not being applied. This patch fixes this issue by refactoring the > code that disables the ASPM-L1SS advertisement. > > Fixes: 56e15a238d92 ("PCI: tegra: Add Tegra194 PCIe support") > Signed-off-by: Vidya Sagar > --- > V4: > * None > > V3: > * None > > V2: > * None > > drivers/pci/controller/dwc/pcie-tegra194.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Looks like this no longer applies cleanly after that other fix that you sent earlier. But looking more closely, that's because that other fix already incorporates an equivalent change, so I think this can be dropped from this series. Thierry