From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC8AEC4361A for ; Fri, 4 Dec 2020 15:02:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE16422B3F for ; Fri, 4 Dec 2020 15:02:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730430AbgLDPBf (ORCPT ); Fri, 4 Dec 2020 10:01:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:60416 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730420AbgLDPBe (ORCPT ); Fri, 4 Dec 2020 10:01:34 -0500 Date: Fri, 4 Dec 2020 16:02:02 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1607094054; bh=r/FRTTah1QcRTa4v/loAf9+zj5pTNfpEuX9XO3neHq8=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=kHTVuwxbCS+OL5mI6RZqzn8irwACv5nQYAwOirdFlDGcckh/dkyT+iN/E+Vf+XcW0 19p7JxayNWBxcEHgZJy4fwFxzEurErLiavI2jKXQXlOrjzDGbmq7v3UH3tAqpPp27W EuKMAq9YEwl46XuY9MaCGk6aB9/2E+pLL8/N0oGU= From: Greg KH To: Hans de Goede Cc: Tom Yan , Alan Stern , Christoph Hellwig , linux-usb , Mathias Nyman , Linux Kernel Mailing List , linux-pci@vger.kernel.org, Lu Baolu Subject: Re: [PATCH 2/2] usb-storage: revert from scsi_add_host_with_dma() to scsi_add_host() Message-ID: References: <09992cec-65e4-2757-aae6-8fb02a42f961@redhat.com> <20201128154849.3193-1-tom.ty89@gmail.com> <20201128154849.3193-2-tom.ty89@gmail.com> <5e62c383-22ea-6df6-5acc-5e9f381d4632@redhat.com> <186eb035-4bc4-ff72-ee41-aeb6d81888e3@redhat.com> <70ca74c2-4a80-e25b-eca9-a63a75516673@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <70ca74c2-4a80-e25b-eca9-a63a75516673@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, Nov 30, 2020 at 02:55:45PM +0100, Hans de Goede wrote: > Hi, > > On 11/30/20 2:53 PM, Greg KH wrote: > > On Mon, Nov 30, 2020 at 02:36:38PM +0100, Hans de Goede wrote: > >> Hi, > >> > >> On 11/30/20 2:30 PM, Greg KH wrote: > >>> On Mon, Nov 30, 2020 at 02:23:48PM +0100, Hans de Goede wrote: > >>>> Hi, > >>>> > >>>> On 11/30/20 1:58 PM, Tom Yan wrote: > >>>>> It's merely a moving of comment moving for/and a no-behavioral-change > >>>>> adaptation for the reversion.> > >>>> > >>>> IMHO the revert of the troublesome commit and the other/new changes really > >>>> should be 2 separate commits. But I will let Alan and Greg have the final > >>>> verdict on this. > >>> > >>> I would prefer to just revert the commits and not do anything > >>> different/special here so late in the release cycle. > >>> > >>> So, if Alan agrees, I'll be glad to do them on my end, I just need the > >>> commit ids for them. > >> > >> The troublesome commit are (in reverse, so revert, order): > >> > >> 5df7ef7d32fe ("uas: bump hw_max_sectors to 2048 blocks for SS or faster drives") > >> 558033c2828f ("uas: fix sdev->host->dma_dev") > >> 0154012f8018 ("usb-storage: fix sdev->host->dma_dev") > >> > >> Alan, the reason for reverting these is that using scsi_add_host_with_dma() as the > >> last 2 patches do, with the dmadev argument of that call pointing to the device > >> for the XHCI controller is causing changes to the DMA settings of the XHCI controller > >> itself which is causing regressions in 5.10, see this email thread: > >> > >> https://lore.kernel.org/linux-usb/fde7e11f-5dfc-8348-c134-a21cb1116285@redhat.com/T/#t > > > > Thanks, I'll wait for Alan to respond, but I think just reverting these > > is the best solution at this point in time. You have tested those > > reverts, solve this, right? If so, can I get a "Tested-by:"? > > Yes that was my first solution to this problem and I can confirm that that fixes > the regression: > > Tested-by: Hans de Goede All now reverted. thanks, greg k-h