From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Lukas Wunner <lukas@wunner.de>,
Chris Chiu <chris.chiu@canonical.com>,
linux-pci@vger.kernel.org, regressions@lists.linux.dev,
linux-cxl@vger.kernel.org, linuxarm@huawei.com
Subject: Re: Regression: Re: [PATCH v2 4/6] PCI: Distribute available resources for root buses too
Date: Mon, 31 Oct 2022 09:40:06 +0200 [thread overview]
Message-ID: <Y1971qnaq6BJObDl@black.fi.intel.com> (raw)
In-Reply-To: <Y1fjT6eyV8KVlNRp@smile.fi.intel.com>
Hi Andy,
On Tue, Oct 25, 2022 at 04:23:27PM +0300, Andy Shevchenko wrote:
> On Tue, Oct 25, 2022 at 03:36:06PM +0300, Mika Westerberg wrote:
> > On Mon, Oct 24, 2022 at 02:25:12PM +0300, Mika Westerberg wrote:
>
> Just for the record in case this code will formally go out
>
> ...
>
> > + for (i = 0; i < PCI_ROM_RESOURCE; i++) {
> > + const struct resource *dev_res = &dev->resource[i];
>
> I believe this is a good candidate to have
>
> #define for_each_pci_dev_resource(dev, res) \
> for (unsigned int i = 0; \
> res = &(dev)->resource[i], i < PCI_ROM_RESOURCE; \
> i++)
>
> Since we have many places in the kernel with such a snippet.
Sure makes sense, but I think that should be a separate patch series.
next prev parent reply other threads:[~2022-10-31 7:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 8:02 [PATCH v2 0/6] PCI: Allow for future resource expansion on initial root bus scan Mika Westerberg
2022-09-05 8:02 ` [PATCH v2 1/6] PCI: Fix used_buses calculation in pci_scan_child_bus_extend() Mika Westerberg
2022-09-05 8:02 ` [PATCH v2 2/6] PCI: Pass available buses also when the bridge is already configured Mika Westerberg
2022-09-05 8:02 ` [PATCH v2 3/6] PCI: Move pci_assign_unassigned_root_bus_resources() Mika Westerberg
2022-09-05 8:02 ` [PATCH v2 4/6] PCI: Distribute available resources for root buses too Mika Westerberg
2022-10-14 11:45 ` Regression: " Jonathan Cameron
2022-10-14 13:30 ` Mika Westerberg
2022-10-14 14:48 ` Jonathan Cameron
2022-10-24 11:13 ` Mika Westerberg
2022-10-24 11:25 ` Mika Westerberg
2022-10-25 12:36 ` Mika Westerberg
2022-10-25 13:23 ` Andy Shevchenko
2022-10-31 7:40 ` Mika Westerberg [this message]
2022-10-25 14:05 ` Jonathan Cameron
2022-10-26 8:38 ` Mika Westerberg
2022-10-26 8:49 ` Regression: Re: [PATCH v2 4/6] PCI: Distribute available resources for root buses too #forregzbot Thorsten Leemhuis
2022-10-26 18:17 ` Thorsten Leemhuis
2022-09-05 8:02 ` [PATCH v2 5/6] PCI: Fix whitespace and indentation Mika Westerberg
2022-09-05 8:02 ` [PATCH v2 6/6] PCI: Fix typo in pci_scan_child_bus_extend() Mika Westerberg
2022-09-21 19:52 ` [PATCH v2 0/6] PCI: Allow for future resource expansion on initial root bus scan Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1971qnaq6BJObDl@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=chris.chiu@canonical.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lukas@wunner.de \
--cc=rafael.j.wysocki@intel.com \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).