linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Luck <tony.luck@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Liang, Kan" <kan.liang@linux.intel.com>,
	bhelgaas@google.com, hdegoede@redhat.com, kernelorg@undead.fr,
	kjhambrick@gmail.com, 2lprbe78@duck.com,
	nicholas.johnson-opensource@outlook.com.au, benoitg@coeus.ca,
	mika.westerberg@linux.intel.com, wse@tuxedocomputers.com,
	mumblingdrunkard@protonmail.com, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, david.e.box@intel.com,
	yunying.sun@intel.com
Subject: Re: Bug report: the extended PCI config space is missed with 6.2-rc2
Date: Thu, 5 Jan 2023 09:42:10 -0800	[thread overview]
Message-ID: <Y7cL8pIqLrwv2z7+@agluck-desk3.sc.intel.com> (raw)
In-Reply-To: <20230104154511.GA1071195@bhelgaas>

On Wed, Jan 04, 2023 at 09:45:11AM -0600, Bjorn Helgaas wrote:
> My understanding is that EfiMemoryMappedIO tells the OS to map the
> area for use by runtime services, but is not intended to prevent the
> OS from using the area.  Some platforms use EfiMemoryMappedIO for PCI
> host bridge apertures, and of course the OS needs to use those.
> 
> If your firmware folks disagree and think Linux should be able to
> figure this out differently, I would love to have a conversation about
> how to do this.

It seems that 07eab0901ede ("efi/x86: Remove EfiMemoryMappedIO from E820 map")
is also the cause of breakage for drivers/edac/sb_edac.c. It is broken
in v6.2-rc2 and reverting this commit makes it work again.

This ancient driver probably plays fast and loose with how it ought to
access extended PCIe config space ... but it needs to do this to read various
memory controller configuration registers to do address translation from
a system physical address to a DIMM address.

-Tony

  reply	other threads:[~2023-01-05 17:42 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04 14:39 Bug report: the extended PCI config space is missed with 6.2-rc2 Liang, Kan
2023-01-04 14:50 ` Bjorn Helgaas
2023-01-04 15:45   ` Bjorn Helgaas
2023-01-05 17:42     ` Tony Luck [this message]
2023-01-05 17:51       ` Bjorn Helgaas
2023-01-05 22:32 ` Bjorn Helgaas
2023-01-05 23:38   ` Dan Williams
2023-01-06  0:22     ` Luck, Tony
2023-01-06  0:47       ` Bjorn Helgaas
2023-01-06 17:33         ` Bjorn Helgaas
2023-01-06 18:03           ` Luck, Tony
2023-01-06 20:52             ` Bjorn Helgaas
2023-01-06 21:37               ` Luck, Tony
2023-01-06 22:04                 ` Bjorn Helgaas
2023-01-06 22:30                   ` Luck, Tony
2023-01-10  5:43                   ` Sun, Yunying
2023-01-10 18:12                   ` Rafael J. Wysocki
2023-01-10 19:06                     ` Bjorn Helgaas
2023-01-06  0:32     ` Bjorn Helgaas
2023-01-06  0:50   ` Liang, Kan
2023-01-09 12:27   ` Giovanni Cabiddu
2023-01-06  9:44 ` Linux kernel regression tracking (#adding)
     [not found] <SJ1PR11MB6083C504335B2DE1B31C440CFCFA9@SJ1PR11MB6083.namprd11.prod.outlook.com>
2023-01-05 18:29 ` Bjorn Helgaas
2023-01-05 19:23   ` Liang, Kan
2023-01-05 19:44     ` Bjorn Helgaas
2023-01-05 19:44   ` Dan Williams
2023-01-05 19:58     ` Luck, Tony
2023-01-05 20:37       ` Bjorn Helgaas
2023-01-05 21:49         ` Luck, Tony
2023-01-05 22:20           ` Bjorn Helgaas
2023-01-05 20:23     ` Bjorn Helgaas
2023-01-05 21:20       ` Dan Williams
2023-01-05 21:35         ` Bjorn Helgaas
2023-01-05 21:43           ` Dan Williams
2023-01-05 21:48             ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y7cL8pIqLrwv2z7+@agluck-desk3.sc.intel.com \
    --to=tony.luck@intel.com \
    --cc=2lprbe78@duck.com \
    --cc=benoitg@coeus.ca \
    --cc=bhelgaas@google.com \
    --cc=david.e.box@intel.com \
    --cc=hdegoede@redhat.com \
    --cc=helgaas@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=kernelorg@undead.fr \
    --cc=kjhambrick@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=mumblingdrunkard@protonmail.com \
    --cc=nicholas.johnson-opensource@outlook.com.au \
    --cc=wse@tuxedocomputers.com \
    --cc=yunying.sun@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).