From: "Krzysztof Wilczyński" <kw@linux.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] PCI/VPD: Remove dead code from sysfs access functions
Date: Wed, 3 Feb 2021 16:22:36 +0100 [thread overview]
Message-ID: <YBq/vOYUQANn8yHN@rocinante> (raw)
In-Reply-To: <267eae86-f8a6-6792-a7f8-2c4fd51beedc@gmail.com>
Hi Heiner,
Thank you for cleaning this up!
On 21-02-03 09:48:03, Heiner Kallweit wrote:
> Since 104daa71b396 ("PCI: Determine actual VPD size on first access")
> attribute size is set to 0 (unlimited). So let's remove this now
> dead code.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> v2:
> - no changes
> ---
> drivers/pci/vpd.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/pci/vpd.c b/drivers/pci/vpd.c
> index 35559ead2..2096530ce 100644
> --- a/drivers/pci/vpd.c
> +++ b/drivers/pci/vpd.c
> @@ -403,13 +403,6 @@ static ssize_t read_vpd_attr(struct file *filp, struct kobject *kobj,
> {
> struct pci_dev *dev = to_pci_dev(kobj_to_dev(kobj));
>
> - if (bin_attr->size > 0) {
> - if (off > bin_attr->size)
> - count = 0;
> - else if (count > bin_attr->size - off)
> - count = bin_attr->size - off;
> - }
> -
> return pci_read_vpd(dev, off, count, buf);
> }
>
> @@ -419,13 +412,6 @@ static ssize_t write_vpd_attr(struct file *filp, struct kobject *kobj,
> {
> struct pci_dev *dev = to_pci_dev(kobj_to_dev(kobj));
>
> - if (bin_attr->size > 0) {
> - if (off > bin_attr->size)
> - count = 0;
> - else if (count > bin_attr->size - off)
> - count = bin_attr->size - off;
> - }
> -
> return pci_write_vpd(dev, off, count, buf);
> }
>
> --
> 2.30.0
>
Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
Krzysztof
next prev parent reply other threads:[~2021-02-03 15:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 8:46 [PATCH v2 0/2] PCI/VPD: Improve handling binary sysfs attribute Heiner Kallweit
2021-02-03 8:48 ` [PATCH v2 1/2] PCI/VPD: Remove dead code from sysfs access functions Heiner Kallweit
2021-02-03 15:22 ` Krzysztof Wilczyński [this message]
2021-02-03 8:50 ` [PATCH v2 2/2] PCI/VPD: Let PCI sysfs core code handle VPD binary attribute Heiner Kallweit
2021-02-03 15:24 ` Krzysztof Wilczyński
2021-03-30 21:53 ` [PATCH v2 0/2] PCI/VPD: Improve handling binary sysfs attribute Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBq/vOYUQANn8yHN@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).