linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Yicong Yang <yangyicong@hisilicon.com>
Cc: helgaas@kernel.org, linux-pci@vger.kernel.org,
	prime.zeng@huawei.com, linuxarm@openeuler.org
Subject: Re: [PATCH] PCI: Use subdir-ccflags-* to inherit debug flag
Date: Thu, 4 Feb 2021 13:28:26 +0100	[thread overview]
Message-ID: <YBvoauS9WagVizdh@rocinante> (raw)
In-Reply-To: <1612438215-33105-1-git-send-email-yangyicong@hisilicon.com>

Hi Yicong,

Thank you for taking care of this!

By the way, did you have some issues with things like pr_debug() and other
things printing debug information not working correctly before?

On 21-02-04 19:30:15, Yicong Yang wrote:
> From: Junhao He <hejunhao2@hisilicon.com>
> 
> Use subdir-ccflags-* instead of ccflags-* to inherit the debug
> settings from Kconfig when traversing subdirectories.
> 
> Signed-off-by: Junhao He <hejunhao2@hisilicon.com>
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
> ---
>  drivers/pci/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/Makefile b/drivers/pci/Makefile
> index 11cc794..d62c4ac 100644
> --- a/drivers/pci/Makefile
> +++ b/drivers/pci/Makefile
> @@ -36,4 +36,4 @@ obj-$(CONFIG_PCI_ENDPOINT)	+= endpoint/
>  obj-y				+= controller/
>  obj-y				+= switch/
>  
> -ccflags-$(CONFIG_PCI_DEBUG) := -DDEBUG
> +subdir-ccflags-$(CONFIG_PCI_DEBUG) := -DDEBUG
> -- 
> 2.8.1

Reviewed-by: Krzysztof Wilczyński <kw@linux.com>

Krzysztof

  reply	other threads:[~2021-02-04 12:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 11:30 Yicong Yang
2021-02-04 12:28 ` Krzysztof Wilczyński [this message]
2021-02-04 13:19   ` Yicong Yang
2021-02-09 13:27     ` Krzysztof Wilczyński
2021-02-10  9:29       ` [Linuxarm] " Yicong Yang
2021-02-04 16:10 ` Bjorn Helgaas
2021-02-05  1:32   ` Yicong Yang
2021-02-09 21:25 ` Bjorn Helgaas
2021-02-09 23:43   ` Krzysztof Wilczyński
2021-02-10  9:33   ` Yicong Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YBvoauS9WagVizdh@rocinante \
    --to=kw@linux.com \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxarm@openeuler.org \
    --cc=prime.zeng@huawei.com \
    --cc=yangyicong@hisilicon.com \
    --subject='Re: [PATCH] PCI: Use subdir-ccflags-* to inherit debug flag' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).