From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 047F3C433E6 for ; Fri, 19 Feb 2021 15:46:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D173064EB1 for ; Fri, 19 Feb 2021 15:46:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230010AbhBSPqe (ORCPT ); Fri, 19 Feb 2021 10:46:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:45688 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229959AbhBSPqZ (ORCPT ); Fri, 19 Feb 2021 10:46:25 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id AE5AC64E46; Fri, 19 Feb 2021 15:45:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613749540; bh=N4kwTHQ5ETlfn2hxyzF8UDx5W5fNe+tnVx+GjwtOP6M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MRkk6KiJsmsavZwpVvzz5nsz978ZzU/lc46ua697r5zasUloRybA58p6EyFGfn0m4 CXORUKsEAUI78yhAHFqAnGfxJJxiyFIcInbgm65vSPGN++wzMGBtC5lsBDPQA+kf1t Qrg7LsUBLeqJncsWAGdNS8e6opCGWIXCXvZMbqp3+MVz654HRnXFQJmVNyxT09c9Lr GVVBP/OnLr3Si+0nU3c7PNnArxfbAq5gkl8uxPjS74+BRjOD/iQxl3Okz3OR/vcicS r+9XadiE96b1pDeRG2c2+mXSUn8kQy94Ud3AotZBAqyBn+fRFu1slpTVSlKIv6fW4C eNdfnTOUVQwVQ== Date: Fri, 19 Feb 2021 16:45:34 +0100 From: Robert Richter To: Dejin Zheng Cc: corbet@lwn.net, jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com, bhelgaas@google.com, wsa@kernel.org, linux-doc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 4/4] i2c: thunderx: Use the correct name of device-managed function Message-ID: References: <20210218150458.798347-1-zhengdejin5@gmail.com> <20210218150458.798347-5-zhengdejin5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210218150458.798347-5-zhengdejin5@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 18.02.21 23:04:58, Dejin Zheng wrote: > Use the new function pcim_alloc_irq_vectors() to allocate IRQ vectors, > the pcim_alloc_irq_vectors() function, an explicit device-managed version > of pci_alloc_irq_vectors(). If pcim_enable_device() has been called > before, then pci_alloc_irq_vectors() is actually a device-managed > function. It is used here as a device-managed function, So replace it > with pcim_alloc_irq_vectors(). > > Signed-off-by: Dejin Zheng The title of this patch suggests there was something incorrect before and this is a fix, which it isn't. Please reword. Thanks, -Robert