linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Robert Richter <rric@kernel.org>
Cc: Dejin Zheng <zhengdejin5@gmail.com>,
	corbet@lwn.net, jarkko.nikula@linux.intel.com,
	andriy.shevchenko@linux.intel.com,
	mika.westerberg@linux.intel.com, helgaas@kernel.org,
	wsa@kernel.org, linux-doc@vger.kernel.org,
	linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/4] PCI: Introduce pcim_alloc_irq_vectors()
Date: Fri, 19 Feb 2021 17:15:50 +0100	[thread overview]
Message-ID: <YC/kNnkusVHg8S0H@rocinante> (raw)
In-Reply-To: <YC/PoOOgRVHa1HIH@rric.localdomain>

Hi Robert,

[...]
> Obiously this is meant here:
> 
> 	if (!pci_is_managed(dev))
[...]

A question to improve my understanding for future reference.  Was the
previous approach of checking for "enabled" flag from struct pci_devres
was not a good choice here?

Krzysztof

  reply	other threads:[~2021-02-19 16:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18 15:04 [PATCH v4 0/4] Introduce pcim_alloc_irq_vectors() Dejin Zheng
2021-02-18 15:04 ` [PATCH v4 1/4] PCI: " Dejin Zheng
2021-02-19 14:40   ` Robert Richter
2021-02-19 14:48     ` Robert Richter
2021-02-19 16:15       ` Krzysztof Wilczyński [this message]
2021-02-22 10:59         ` Robert Richter
2021-02-19 14:48     ` Andy Shevchenko
2021-02-19 15:01       ` Robert Richter
2021-02-19 16:46     ` Dejin Zheng
2021-02-22 10:56       ` Robert Richter
2021-02-22 15:14         ` Dejin Zheng
2021-02-23  8:02           ` Robert Richter
2021-02-23 14:14             ` Dejin Zheng
2021-02-25  9:33               ` Robert Richter
2021-02-26 15:22                 ` Dejin Zheng
2021-02-18 15:04 ` [PATCH v4 2/4] Documentation: devres: Add pcim_alloc_irq_vectors() Dejin Zheng
2021-02-18 15:04 ` [PATCH v4 3/4] i2c: designware: Use the correct name of device-managed function Dejin Zheng
2021-02-18 15:35   ` Andy Shevchenko
2021-02-18 15:04 ` [PATCH v4 4/4] i2c: thunderx: " Dejin Zheng
2021-02-19 15:45   ` Robert Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YC/kNnkusVHg8S0H@rocinante \
    --to=kw@linux.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=corbet@lwn.net \
    --cc=helgaas@kernel.org \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rric@kernel.org \
    --cc=wsa@kernel.org \
    --cc=zhengdejin5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).