From: "'Krzysztof Wilczyński'" <firstname.lastname@example.org> To: "Zhuo, Qiuxu" <email@example.com> Cc: Bjorn Helgaas <firstname.lastname@example.org>, "Kelley, Sean V" <email@example.com>, "Luck, Tony" <firstname.lastname@example.org>, "Jin, Wen" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com> Subject: Re: [PATCH 1/1] PCI/RCEC: Fix failure to inject errors to some RCiEP devices Date: Thu, 18 Feb 2021 23:11:34 +0100 [thread overview] Message-ID: <YC7mFsfTlVsW9Uo1@rocinante> (raw) In-Reply-To: <YC7lE2Ph/MHxNKs+@rocinante> Hi Qiuxu, [...] > > Agree to simplify the commit message. How about the following subject and commit message? > > > > Subject: > > Use device number to check RCiEPBitmap of RCEC > > > > Commit message: > > rcec_assoc_rciep() used the combination of device number and function > > number 'devfn' to check whether the corresponding bit in the > > RCiEPBimap of RCEC was set. According to , it only needs to use the > > device number to check the corresponding bit in the RCiEPBitmap was > > set. So fix it by using PCI_SLOT() to convert 'devfn' to device number > > for rcec_assoc_rciep().  PCIe r5.0, sec "220.127.116.11 Association > > Bitmap for RCiEPs" > > I took your suggestion and came up with the following: > > Function rcec_assoc_rciep() incorrectly used "rciep->devfn" (a single > byte encoding the device and function number) as the device number to > check whether the corresponding bit was set in the RCiEPBitmap of the > RCEC (Root Complex Event Collector) while enumerating over each bit of > the RCiEPBitmap. > > As per the PCI Express Base Specification, Revision 5.0, Version 1.0, > Section 18.104.22.168, "Association Bitmap for RCiEPs", p. 935, only needs to > use a device number to check whether the corresponding bit was set in > the RCiEPBitmap. > > Fix rcec_assoc_rciep() using the PCI_SLOT() macro and convert the value > of "rciep->devfn" to a device number to ensure that the RCiEP devices > are associated with the RCEC are linked when the RCEC is enumerated. > > Using either of the following as the subject: > > PCI/RCEC: Use device number to check RCiEPBitmap of RCEC > PCI/RCEC: Fix RCiEP capable devices RCEC association > > What do you think? Also, feel free to change whatever you see fit, of > course, as tis is only a suggestion. We could probably add the following: Fixes: 507b460f8144 ("PCI/ERR: Add pcie_link_rcec() to associate RCiEPs") Since this would where the issue was originally introduced. I forgot to mention this in the previous message, apologies. Krzysztof
next prev parent reply other threads:[~2021-02-18 22:12 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-10 2:05 Qiuxu Zhuo 2021-02-10 4:33 ` Kelley, Sean V 2021-02-10 17:12 ` Krzysztof Wilczyński 2021-02-18 3:00 ` Zhuo, Qiuxu 2021-02-18 22:07 ` 'Krzysztof Wilczyński' 2021-02-18 22:11 ` 'Krzysztof Wilczyński' [this message] 2021-02-19 1:52 ` Zhuo, Qiuxu 2021-02-19 2:23 ` [PATCH v2 1/1] PCI/RCEC: Fix RCiEP capable devices RCEC association Qiuxu Zhuo 2021-02-22 0:56 ` Krzysztof Wilczyński 2021-02-22 1:04 ` Zhuo, Qiuxu 2021-02-22 1:17 ` [PATCH v3 " Qiuxu Zhuo 2021-03-05 6:12 ` Zhuo, Qiuxu 2021-03-10 22:00 ` Bjorn Helgaas 2021-03-11 3:13 ` Zhuo, Qiuxu 2021-02-19 1:51 ` [PATCH 1/1] PCI/RCEC: Fix failure to inject errors to some RCiEP devices Zhuo, Qiuxu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YC7mFsfTlVsW9Uo1@rocinante \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 1/1] PCI/RCEC: Fix failure to inject errors to some RCiEP devices' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).