linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kw@linux.com>
To: "Martin Hundebøll" <mhu@silicom.dk>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci: add Silicom Denmark vendor id
Date: Mon, 8 Feb 2021 15:54:33 +0100	[thread overview]
Message-ID: <YCFQqSR3ABtDQBaL@rocinante> (raw)
In-Reply-To: <20210208132832.2833630-1-mhu@silicom.dk>

Hi Martin,

Thank you for sending the patch over!

A few suggestions.  Try to keep the patch style aligned with previous
submissions, see the following for to format the subject line, etc.,
a few examples:

$ git log --oneline include/linux/pci_ids.h | grep -E 'Add.*ID' | head -n 10
8b7beaf9f185 PCI: Add Intel QuickAssist device IDs
a4e91825d7e1 x86/amd_nb: Add AMD family 17h model 60h PCI IDs
3375590623e4 PCI: Add Zhaoxin Vendor ID
9acb9fe18d86 PCI: Add Loongson vendor ID
b3f79ae45904 x86/amd_nb: Add Family 19h PCI IDs
4a36a60c34f4 PCI: Add Amazon's Annapurna Labs vendor ID
4460d68f0b2f PCI: Add Genesys Logic, Inc. Vendor ID
af4e1c5eca95 x86/amd_nb: Add PCI device IDs for family 17h, model 70h
1f418f46503d PCI: Add Synopsys endpoint EDDA Device ID
b8580e9de48b PCI: Add HXT vendor ID

If you have a moment, see [1] which you can use as a guide for patches
submissions against the PCI sub-system.

[...]
> Update pci_ids.h with the vendor id for Silicom Denmark.

It would be "ID" here.

[...
> +#define PCI_VENDOR_ID_SILICOM_DENMARK	0x1c2c

Are they any drivers for this new device already?

1. https://lore.kernel.org/linux-pci/20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com/

Krzysztof

      reply	other threads:[~2021-02-08 14:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-08 13:28 [PATCH] pci: add Silicom Denmark vendor id Martin Hundebøll
2021-02-08 14:54 ` Krzysztof Wilczyński [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YCFQqSR3ABtDQBaL@rocinante \
    --to=kw@linux.com \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mhu@silicom.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).