From: "Krzysztof Wilczyński" <kw@linux.com>
To: Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>
Cc: "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Derek Kiernan <derek.kiernan@xilinx.com>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [RESEND v4 4/6] Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver
Date: Tue, 9 Feb 2021 00:11:48 +0100 [thread overview]
Message-ID: <YCHFNKb5TcCYj5Uy@rocinante> (raw)
In-Reply-To: <DM5PR12MB18357C5DF57458FD4ECA9E9BDA8F9@DM5PR12MB1835.namprd12.prod.outlook.com>
Hi Gustavo,
[...]
> > When I do the following:
> >
> > # echo 1 > /sys/kernel/dw-xdata-pcie/write
> > # echo 1 > /sys/kernel/dw-xdata-pcie/stop
> > # cat /sys/kernel/dw-xdata-pcie/write
> >
> > Would output from cat above simply show "0 MB/s" then? I wonder how
> > someone using this new driver could tell whether "write" or "read"
> > traffic generation has been enabled aside of reading the sysfs files,
> > would adding "/sys/kernel/dw-xdata-pcie/active" be an overkill here?
> >
> > What do you think?
>
> Yes, it would display 0 MB/s. This driver is to be used mainly by the
> Synopsys DesignWare HW prototyping team. I don't think the general public
> will be interested or can use this driver, because requires a special HW
> block available only for this prototype.
Got it.
> I tried to reduce to the minimal the interfaces, to avoid possible
> confusion. For instance, even the /sys/kernel/dw-xdata-pcie/stop
> interface could be avoided, because on the driver unloading or changing
> the between write or read it calls the stop procedure.
Oh, OK.
> Due to the nature of the HW block, it only can allow the write or the
> read at some given moment, therefore based on the last command enable
> write or read, we know which mode is this driving working.
> This driver will be used by the testing team on their automation scripts,
> thus they will know exactly the sequence input.
>
> Anyway, thanks for your feedback.
Thank you for taking the time to add more details for me. Much
appreciated.
Krzysztof
next prev parent reply other threads:[~2021-02-08 23:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 22:12 [RESEND v4 0/6] misc: Add Add Synopsys DesignWare xData IP driver Gustavo Pimentel
2021-02-03 22:12 ` [RESEND v4 1/6] misc: " Gustavo Pimentel
2021-02-03 22:33 ` Greg Kroah-Hartman
2021-02-07 1:36 ` Krzysztof Wilczyński
2021-02-08 11:21 ` Gustavo Pimentel
2021-02-08 22:53 ` Krzysztof Wilczyński
2021-02-09 15:28 ` Gustavo Pimentel
2021-02-09 17:24 ` Krzysztof Wilczyński
2021-02-09 18:52 ` Bjorn Helgaas
2021-02-03 22:12 ` [RESEND v4 2/6] misc: Add Synopsys DesignWare xData IP driver to Makefile Gustavo Pimentel
2021-02-03 22:12 ` [RESEND v4 3/6] misc: Add Synopsys DesignWare xData IP driver to Kconfig Gustavo Pimentel
2021-02-03 22:26 ` Greg Kroah-Hartman
2021-02-03 22:27 ` Greg Kroah-Hartman
2021-02-03 22:12 ` [RESEND v4 4/6] Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver Gustavo Pimentel
2021-02-06 23:31 ` Krzysztof Wilczyński
2021-02-08 9:24 ` Gustavo Pimentel
2021-02-08 23:11 ` Krzysztof Wilczyński [this message]
2021-02-03 22:12 ` [RESEND v4 5/6] MAINTAINERS: Add Synopsys xData IP driver maintainer Gustavo Pimentel
2021-02-03 22:12 ` [RESEND v4 6/6] docs: ABI: Add sysfs documentation interface of dw-xdata-pcie driver Gustavo Pimentel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCHFNKb5TcCYj5Uy@rocinante \
--to=kw@linux.com \
--cc=Gustavo.Pimentel@synopsys.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=derek.kiernan@xilinx.com \
--cc=dragan.cvetic@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).