linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Yicong Yang <yangyicong@hisilicon.com>
Cc: helgaas@kernel.org, linux-pci@vger.kernel.org,
	prime.zeng@huawei.com, linuxarm@openeuler.org
Subject: Re: [PATCH] PCI: Use subdir-ccflags-* to inherit debug flag
Date: Tue, 9 Feb 2021 14:27:47 +0100	[thread overview]
Message-ID: <YCKN0+wsH/W2lZ+Q@rocinante> (raw)
In-Reply-To: <3171ed82-c114-2298-1c03-f7c854fb15c0@hisilicon.com>

Hi Yicong,

[...]
> > By the way, did you have some issues with things like pr_debug() and other
> > things printing debug information not working correctly before?
> 
> i cannot remember that i have met any, so maybe they work properly. :)
[...]

That's good to know!  I suspect, some of the pr_debug() invocations
might not be working correctly at the moment, so this is a nice
improvement.

Having said that, if you have some time, can you update the patch
against the PCI tree with the commit message from this thread?

  https://lore.kernel.org/lkml/1612868899-9185-1-git-send-email-yangyicong@hisilicon.com/

The commit messages there for the individual patches are much nicer, so
if you don't mind, it would be nice have the same one in the PCI tree.

My review still applies.

Thank you again for sending the patch over!

Krzysztof

  reply	other threads:[~2021-02-09 13:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 11:30 Yicong Yang
2021-02-04 12:28 ` Krzysztof Wilczyński
2021-02-04 13:19   ` Yicong Yang
2021-02-09 13:27     ` Krzysztof Wilczyński [this message]
2021-02-10  9:29       ` [Linuxarm] " Yicong Yang
2021-02-04 16:10 ` Bjorn Helgaas
2021-02-05  1:32   ` Yicong Yang
2021-02-09 21:25 ` Bjorn Helgaas
2021-02-09 23:43   ` Krzysztof Wilczyński
2021-02-10  9:33   ` Yicong Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YCKN0+wsH/W2lZ+Q@rocinante \
    --to=kw@linux.com \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxarm@openeuler.org \
    --cc=prime.zeng@huawei.com \
    --cc=yangyicong@hisilicon.com \
    --subject='Re: [PATCH] PCI: Use subdir-ccflags-* to inherit debug flag' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).