From: "Krzysztof Wilczyński" <email@example.com> To: Qiuxu Zhuo <firstname.lastname@example.org> Cc: Bjorn Helgaas <email@example.com>, Sean V Kelley <firstname.lastname@example.org>, "Luck, Tony" <email@example.com>, "Jin, Wen" <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH 1/1] PCI/RCEC: Fix failure to inject errors to some RCiEP devices Date: Wed, 10 Feb 2021 18:12:36 +0100 [thread overview] Message-ID: <YCQT90mK1kacZ7ZA@rocinante> (raw) In-Reply-To: <email@example.com> Hi Qiuxu, Nice catch! Thank you for sending the fix over! [...] > On a Sapphire Rapids server, it failed to inject correctable errors > to the RCiEP device e8:02.0 which was associated with the RCEC device > e8:00.4. See the following error log before applying the patch: > > aer-inject -s e8:02.0 examples/correctable > Error: Failed to write, No such device > > This was because rcec_assoc_rciep() mistakenly used "rciep->devfn" as > device number to check whether the corresponding bit was set in > the RCiEPBitmap of the RCEC. So that the RCiEP device e8:02.0 wasn't > linked to the RCEC and resulted in the above error. > > Fix it by using PCI_SLOT() to convert rciep->devfn to device number. > Ensure that the RCiEP devices associated with the RCEC are linked to > the RCEC as the RCEC is enumerated. After applying the patch, correctable > errors can be injected to the RCiEP successfully. Would this only affect error injection or would this be also a generic problem with the driver itself causing issues regardless of whether it was an error injection or not for this particular device? I am asking, as there is a lot going on in the commit message. I wonder if simplifying this commit message so that it clearly explains what was broken, why, and how this patch is fixing it, would perhaps be an option? The backstory of how you found the issue while doing some testing and error injection is nice, but not sure if needed. What do you think? Krzysztof
next prev parent reply other threads:[~2021-02-10 17:14 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-10 2:05 Qiuxu Zhuo 2021-02-10 4:33 ` Kelley, Sean V 2021-02-10 17:12 ` Krzysztof Wilczyński [this message] 2021-02-18 3:00 ` Zhuo, Qiuxu 2021-02-18 22:07 ` 'Krzysztof Wilczyński' 2021-02-18 22:11 ` 'Krzysztof Wilczyński' 2021-02-19 1:52 ` Zhuo, Qiuxu 2021-02-19 2:23 ` [PATCH v2 1/1] PCI/RCEC: Fix RCiEP capable devices RCEC association Qiuxu Zhuo 2021-02-22 0:56 ` Krzysztof Wilczyński 2021-02-22 1:04 ` Zhuo, Qiuxu 2021-02-22 1:17 ` [PATCH v3 " Qiuxu Zhuo 2021-03-05 6:12 ` Zhuo, Qiuxu 2021-03-10 22:00 ` Bjorn Helgaas 2021-03-11 3:13 ` Zhuo, Qiuxu 2021-02-19 1:51 ` [PATCH 1/1] PCI/RCEC: Fix failure to inject errors to some RCiEP devices Zhuo, Qiuxu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YCQT90mK1kacZ7ZA@rocinante \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 1/1] PCI/RCEC: Fix failure to inject errors to some RCiEP devices' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).