From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>,
Aaron Ma <aaron.ma@canonical.com>,
Alan Stern <stern@rowland.harvard.edu>,
Lee Jones <lee.jones@linaro.org>,
peter.chen@nxp.com, USB list <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Linux PCI <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] xhci-pci: Set AMD Renoir USB controller to D3 when shutdown
Date: Thu, 11 Feb 2021 13:50:12 +0100 [thread overview]
Message-ID: <YCUoBP4GUrGL0J3J@kroah.com> (raw)
In-Reply-To: <00de6927-3fa6-a9a3-2d65-2b4d4e8f0012@linux.intel.com>
On Wed, Feb 10, 2021 at 03:13:30PM +0200, Mathias Nyman wrote:
> On 9.2.2021 10.37, Greg Kroah-Hartman wrote:
> > On Fri, Feb 05, 2021 at 02:50:15PM +0800, Kai-Heng Feng wrote:
> >> On Fri, Feb 5, 2021 at 2:45 PM Aaron Ma <aaron.ma@canonical.com> wrote:
> >>>
> >>>
> >>> On 2/5/21 12:27 PM, Kai-Heng Feng wrote:
> >>>> Can you please test the following patch, which should address the root cause:
> >>>> https://lore.kernel.org/linux-acpi/20201201213019.1558738-1-furquan@google.com/
> >>>>
> >>>> It also helps another AMD laptop on S5:
> >>>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1912935
> >>>>
> >>>
> >>> No, this patch doesn't help on ThinkPad AMD platform.
> >>
> >> Thanks for the confirmation!
> >>
> >> Acked-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> >
> > Mathias, want me to take this in my tree now, or are you going to send
> > me more patches for 5.12-rc1?
> >
>
> Nothing more for 5.12-rc1 from me.
>
> Could this be a PCI quirk instead of xhci?
> Maybe there is some PCI flag for this already, haven't checked yet.
>
> We want a specific PCI device to go to PCI D3cold at PCI shutdown...
There probably is. Kay-Heng, can you look into doing that instead?
thanks,
greg k-h
next prev parent reply other threads:[~2021-02-11 12:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210204051850.64857-1-aaron.ma@canonical.com>
[not found] ` <CAAd53p4euFiw7pfDnD2H8oMVeeTqQ_c+wOFDLM2xPccn5MewiA@mail.gmail.com>
[not found] ` <cd4595e6-67da-885c-1a67-6dfd71425b8c@canonical.com>
[not found] ` <CAAd53p4z1ydFi5pwOZJnsrBDPNVLKU0ygqa0+kdZdXWYocPLgQ@mail.gmail.com>
[not found] ` <YCJJrVp2DvCzigCw@kroah.com>
2021-02-10 13:13 ` [PATCH] xhci-pci: Set AMD Renoir USB controller to D3 when shutdown Mathias Nyman
2021-02-11 12:50 ` Greg Kroah-Hartman [this message]
2021-02-19 8:07 ` Aaron Ma
2021-02-22 5:56 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCUoBP4GUrGL0J3J@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aaron.ma@canonical.com \
--cc=bhelgaas@google.com \
--cc=kai.heng.feng@canonical.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=peter.chen@nxp.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).