From: Robert Richter <rric@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Arnd Bergmann" <arnd@arndb.de>, "Rob Herring" <robh@kernel.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Kuppuswamy Sathyanarayanan"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Sean V Kelley" <sean.v.kelley@intel.com>,
"Qiuxu Zhuo" <qiuxu.zhuo@intel.com>,
"David E. Box" <david.e.box@linux.intel.com>,
"Yicong Yang" <yangyicong@hisilicon.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI: controller: thunder: fix compile testing
Date: Fri, 26 Feb 2021 16:12:31 +0100 [thread overview]
Message-ID: <YDkP3xwbKi1Cp6aX@rric.localdomain> (raw)
In-Reply-To: <20210225143727.3912204-1-arnd@kernel.org>
On 25.02.21 15:37:09, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Compile-testing these drivers is currently broken. Enabling
> it causes a couple of build failures though:
>
> drivers/pci/controller/pci-thunder-ecam.c:119:30: error: shift count >= width of type [-Werror,-Wshift-count-overflow]
> drivers/pci/controller/pci-thunder-pem.c:54:2: error: implicit declaration of function 'writeq' [-Werror,-Wimplicit-function-declaration]
> drivers/pci/controller/pci-thunder-pem.c:392:8: error: implicit declaration of function 'acpi_get_rc_resources' [-Werror,-Wimplicit-function-declaration]
>
> Fix them with the obvious one-line changes.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Robert Richter <rric@kernel.org>
> ---
> drivers/pci/controller/pci-thunder-ecam.c | 2 +-
> drivers/pci/controller/pci-thunder-pem.c | 13 +++++++------
> drivers/pci/pci.h | 6 ++++++
> 3 files changed, 14 insertions(+), 7 deletions(-)
prev parent reply other threads:[~2021-02-26 15:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 14:37 [PATCH 1/2] PCI: controller: thunder: fix compile testing Arnd Bergmann
2021-02-25 14:37 ` [PATCH 2/2] PCI: controller: avoid building empty drivers Arnd Bergmann
2021-02-26 19:08 ` Robert Richter
2021-02-27 12:31 ` Arnd Bergmann
2021-02-25 17:44 ` [PATCH 1/2] PCI: controller: thunder: fix compile testing Kuppuswamy, Sathyanarayanan
2021-02-25 18:51 ` Bjorn Helgaas
2021-02-25 19:15 ` Kuppuswamy, Sathyanarayanan
2021-02-26 15:12 ` Robert Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDkP3xwbKi1Cp6aX@rric.localdomain \
--to=rric@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=david.e.box@linux.intel.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=qiuxu.zhuo@intel.com \
--cc=robh@kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=sean.v.kelley@intel.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).