From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEA95C433E6 for ; Wed, 10 Mar 2021 20:11:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA9B164FD4 for ; Wed, 10 Mar 2021 20:11:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229595AbhCJUKz (ORCPT ); Wed, 10 Mar 2021 15:10:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:53994 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230525AbhCJUKq (ORCPT ); Wed, 10 Mar 2021 15:10:46 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id F17B564F93; Wed, 10 Mar 2021 20:10:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615407045; bh=HD9VOBnSGTScWxDQSoGkCML5OLKSaqNVSIokZCpoYlM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tDnak1ZVJo+WYG8QcQjzTWALZl8cHkT2vyBdWTTxelJi49bpb4jnBsnLBBy3UBSk3 dhQ77xG8vFZXBTE79T/c2LTE8QT+U652as09oaK5m7xaVE5/berbfUUGmfs6eo6djN D+XaprlqGWzcerDntgG9qGLkwf7tC6yvzqnQPE30eCUyQD8LI4Q5aJmtjjY2X1Ukk5 ZyGRaZr1bTbQsvwEYmJAP0Nmau/gPYDy0oBlUFll4NffVQbrEAypaCmGAYaEhpxN6k DqgrOPdGaD+p+FNmRziOrCzOX+3Pe4fxerGmMnxnRuxoV8veJIPUl3ocu6mo5kWWeH ueR1Zb+dnl0eQ== Date: Wed, 10 Mar 2021 22:10:41 +0200 From: Leon Romanovsky To: Bjorn Helgaas Cc: Alexander Duyck , Bjorn Helgaas , Saeed Mahameed , Jason Gunthorpe , Jakub Kicinski , linux-pci , linux-rdma@vger.kernel.org, Netdev , Don Dutile , Alex Williamson , "David S . Miller" , Greg Kroah-Hartman Subject: Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count Message-ID: References: <20210310190906.GA2020121@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210310190906.GA2020121@bjorn-Precision-5520> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Mar 10, 2021 at 01:09:06PM -0600, Bjorn Helgaas wrote: > On Sun, Mar 07, 2021 at 10:55:24AM -0800, Alexander Duyck wrote: > > On Sun, Feb 28, 2021 at 11:55 PM Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > @Alexander Duyck, please update me if I can add your ROB tag again > > > to the series, because you liked v6 more. > > > > > > Thanks > > > > > > --------------------------------------------------------------------------------- > > > Changelog > > > v7: > > > * Rebase on top v5.12-rc1 > > > * More english fixes > > > * Returned to static sysfs creation model as was implemented in v0/v1. <...> > 2) Should a VF sysfs file use the PF to implement this? > > Can you elaborate on your idea here? I guess > pci_iov_sysfs_link() makes a "virtfnX" link from the PF to the > VF, and you're thinking we could also make a "virtfnX_msix_count" > in the PF directory? That's a really interesting idea. I want to remind that we are talking about mlx5 devices that support upto 255 VFs and they indeed are used to their limits. So seeing 255 links of virtfnX_msix_count in the same directory looks too much unpleasant to me. Thanks