linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Yicong Yang <yangyicong@hisilicon.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
	linuxarm@huawei.com, prime.zeng@huawei.com
Subject: Re: [PATCH] PCI/AER: Use consistent format when print PCI device
Date: Fri, 26 Mar 2021 11:16:52 +0100	[thread overview]
Message-ID: <YF20lDlJlikTKNkI@rocinante> (raw)
In-Reply-To: <1616752057-9720-1-git-send-email-yangyicong@hisilicon.com>

Hi Yicong,

> We use format domain:bus:slot.function when print
> PCI device. Use consistent format in AER messages.

A small nitpick: the commit message and in the subject line it should
probably use "printing" rather than "print".  But I suppose whoever is
going be applying this patch can fix this, so probably no need to send
another version, unless you really want to do it.

[...]
> -			pr_err("AER recover: Can not find pci_dev for %04x:%02x:%02x:%x\n",
> +			pr_err("AER recover: Can not find pci_dev for %04x:%02x:%02x.%x\n",
>  			       entry.domain, entry.bus,
>  			       PCI_SLOT(entry.devfn), PCI_FUNC(entry.devfn));
[...]
> -		pr_err("AER recover: Buffer overflow when recovering AER for %04x:%02x:%02x:%x\n",
> +		pr_err("AER recover: Buffer overflow when recovering AER for %04x:%02x:%02x.%x\n",
>  		       domain, bus, PCI_SLOT(devfn), PCI_FUNC(devfn));

Seems like a good idea!  This BDF-like notation is used at few other
places.  Nice catch.

Reviewed-by: Krzysztof Wilczyński <kw@linux.com>

Krzysztof

  reply	other threads:[~2021-03-26 10:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26  9:47 Yicong Yang
2021-03-26 10:16 ` Krzysztof Wilczyński [this message]
2021-03-29 10:54   ` Yicong Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YF20lDlJlikTKNkI@rocinante \
    --to=kw@linux.com \
    --cc=bhelgaas@google.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=prime.zeng@huawei.com \
    --cc=yangyicong@hisilicon.com \
    --subject='Re: [PATCH] PCI/AER: Use consistent format when print PCI device' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).