linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Richard Zhu <hongxing.zhu@nxp.com>
Cc: l.stach@pengutronix.de, andrew.smirnov@gmail.com,
	shawnguo@kernel.org, bhelgaas@google.com, stefan@agner.ch,
	lorenzo.pieralisi@arm.com, linux-pci@vger.kernel.org,
	linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v3 3/3] PCI: imx: clear vreg bypass when pcie vph voltage is 3v3
Date: Fri, 26 Mar 2021 08:45:42 +0100	[thread overview]
Message-ID: <YF2RJib3k8RiYF4S@rocinante> (raw)
In-Reply-To: <1616661882-26487-4-git-send-email-hongxing.zhu@nxp.com>

Hi,

> +		/*
> +		 * Regarding to the datasheet, the PCIE_VPH is suggested
> +		 * to be 1.8V. If the PCIE_VPH is supplied by 3.3V, the
> +		 * VREG_BYPASS should be cleared to zero.
> +		 */
[...]

A small nitpick here.  What about the following:

	Regarding the data sheet, the PCIE_VPH is suggested to be 1.8V.
	If the PCIE_VPH is supplied with 3.3V, the VREG_BYPASS should be
	cleared to zero.

What do you think?

Krzysztof

  reply	other threads:[~2021-03-26  7:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-25  8:44 [PATCH v3 0/3] add one regulator used to power up pcie phy Richard Zhu
2021-03-25  8:44 ` [PATCH v3 1/3] dt-bindings: imx6q-pcie: " Richard Zhu
2021-03-26  9:37   ` Lucas Stach
2021-03-25  8:44 ` [PATCH v3 2/3] arm64: dts: imx8mq-evk: " Richard Zhu
2021-03-26  9:40   ` Lucas Stach
2021-03-25  8:44 ` [PATCH v3 3/3] PCI: imx: clear vreg bypass when pcie vph voltage is 3v3 Richard Zhu
2021-03-26  7:45   ` Krzysztof Wilczyński [this message]
2021-03-26  9:41   ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YF2RJib3k8RiYF4S@rocinante \
    --to=kw@linux.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=hongxing.zhu@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=shawnguo@kernel.org \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).