linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: Disable D3cold support on Intel XMM7360
@ 2021-03-24 11:13 Kai-Heng Feng
  2021-03-26  9:25 ` Krzysztof Wilczyński
  0 siblings, 1 reply; 2+ messages in thread
From: Kai-Heng Feng @ 2021-03-24 11:13 UTC (permalink / raw)
  To: bhelgaas; +Cc: Kai-Heng Feng, open list:PCI SUBSYSTEM, open list

On some platforms, the root port for Intel XMM7360 WWAN supports D3cold.
When the root port is put to D3cold by system suspend or runtime
suspend, attempt to systems resume or runtime resume will freeze the
laptop for a while, then it automatically shuts down.

The root cause is unclear for now, as the Intel XMM7360 doesn't have a
driver yet.

So disable D3cold for XMM7360 as a workaround, until proper device
driver is in place.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=212419
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
 drivers/pci/quirks.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 653660e3ba9e..8ca8153e4a19 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -5612,3 +5612,10 @@ static void apex_pci_fixup_class(struct pci_dev *pdev)
 }
 DECLARE_PCI_FIXUP_CLASS_HEADER(0x1ac1, 0x089a,
 			       PCI_CLASS_NOT_DEFINED, 8, apex_pci_fixup_class);
+
+static void pci_fixup_no_d3cold(struct pci_dev *pdev)
+{
+	pci_info(pdev, "disable D3cold\n");
+	pci_d3cold_disable(pdev);
+}
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x7360, pci_fixup_no_d3cold);
-- 
2.30.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] PCI: Disable D3cold support on Intel XMM7360
  2021-03-24 11:13 [PATCH] PCI: Disable D3cold support on Intel XMM7360 Kai-Heng Feng
@ 2021-03-26  9:25 ` Krzysztof Wilczyński
  0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Wilczyński @ 2021-03-26  9:25 UTC (permalink / raw)
  To: Kai-Heng Feng; +Cc: bhelgaas, open list:PCI SUBSYSTEM, open list

Hi,

Thank you for sending the patch over!

[...]
> +static void pci_fixup_no_d3cold(struct pci_dev *pdev)
> +{
> +	pci_info(pdev, "disable D3cold\n");

Not sure how useful this message would generally be?  Unless this is
useful to someone who is doing some troubleshooting, etc.

> +	pci_d3cold_disable(pdev);
> +}
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x7360, pci_fixup_no_d3cold);
[...]

A small suggestion: a brief comment, perhaps even linking to the
Bugzilla, might be a nice touch here, so that people would know why
D3cold is being disabled for XMM7360, etc.

Krzysztof

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-26  9:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-24 11:13 [PATCH] PCI: Disable D3cold support on Intel XMM7360 Kai-Heng Feng
2021-03-26  9:25 ` Krzysztof Wilczyński

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).