From: Greg Kroah-Hartman <email@example.com> To: Gustavo Pimentel <Gustavo.Pimentel@synopsys.com> Cc: firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, "Derek Kiernan" <email@example.com>, "Dragan Cvetic" <firstname.lastname@example.org>, "Arnd Bergmann" <email@example.com>, "Andrew Morton" <firstname.lastname@example.org>, "Jonathan Corbet" <email@example.com>, "Bjorn Helgaas" <firstname.lastname@example.org>, "Krzysztof Wilczyński" <email@example.com> Subject: Re: [PATCH v8 5/5] FIX driver Date: Mon, 29 Mar 2021 12:06:17 +0200 [thread overview] Message-ID: <YGGmmfSO/tjYZB9k@kroah.com> (raw) In-Reply-To: <firstname.lastname@example.org> On Mon, Mar 29, 2021 at 11:51:38AM +0200, Gustavo Pimentel wrote: > Signed-off-by: Gustavo Pimentel <email@example.com> > --- > drivers/misc/dw-xdata-pcie.c | 99 +++++++++++++++++++++++++------------------- > 1 file changed, 57 insertions(+), 42 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
prev parent reply other threads:[~2021-03-29 10:07 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-29 9:51 [PATCH v8 0/5] misc: Add Add Synopsys DesignWare xData IP driver Gustavo Pimentel 2021-03-29 9:51 ` [PATCH v8 1/5] misc: " Gustavo Pimentel 2021-03-29 9:51 ` [PATCH v8 2/5] Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver Gustavo Pimentel 2021-03-29 9:51 ` [PATCH v8 3/5] MAINTAINERS: Add Synopsys xData IP driver maintainer Gustavo Pimentel 2021-03-29 9:51 ` [PATCH v8 4/5] docs: ABI: Add sysfs documentation interface of dw-xdata-pcie driver Gustavo Pimentel 2021-03-29 9:51 ` [PATCH v8 5/5] FIX driver Gustavo Pimentel 2021-03-29 10:03 ` Willy Tarreau 2021-03-29 10:09 ` Gustavo Pimentel 2021-03-29 10:06 ` Greg Kroah-Hartman [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YGGmmfSO/tjYZB9k@kroah.com \ --firstname.lastname@example.org \ --cc=Gustavo.Pimentel@synopsys.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v8 5/5] FIX driver' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).