From: Christoph Hellwig <hch@infradead.org>
To: Robert Straw <drbawb@fatalsyntax.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH] pci: add NVMe FLR quirk to the SM951 SSD
Date: Wed, 19 May 2021 09:44:08 +0100 [thread overview]
Message-ID: <YKTP2GQkLz5jma/q@infradead.org> (raw)
In-Reply-To: <CBDZPI1DXKMS.88UVUXVIGC5V@nagato>
On Sat, May 15, 2021 at 12:20:05PM -0500, Robert Straw wrote:
> On page 40, sec 3.1.6 of the NVMe 1.1 spec, the documentation on SHST
> states the following:
While it doesn't matter here, NVMe 1.1 is very much out of data, being
a more than 8 year old specification. The current version is 1.4b,
with NVMe 2.0 about to be released.
> Knowing this I would suspect we'd actually want to treat most NVMe
> drives in this manner *if the kernel sees the SHN/SHST has been set
> prior.* Perhaps other NVMe devices are more tolerant of not doing this?
No, we don't. This is a bug particular to a specific implementation.
In fact the whole existing NVMe shutdown before reset quirk is rather
broken and dangerous, as it concurrently accesses the NVMe registers
with the actual driver, which could be trivially triggered through the
sysfs reset attribute.
I'd much rather quirk these broken Samsung drivers to not allow
assigning them to VFIO.
next prev parent reply other threads:[~2021-05-19 8:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 23:07 [PATCH] pci: add NVMe FLR quirk to the SM951 SSD Robert Straw
2021-04-30 20:51 ` Bjorn Helgaas
2021-04-30 22:34 ` Robert Straw
2021-05-15 17:20 ` Robert Straw
2021-05-19 8:44 ` Christoph Hellwig [this message]
2021-05-19 12:54 ` Robert Straw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKTP2GQkLz5jma/q@infradead.org \
--to=hch@infradead.org \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=drbawb@fatalsyntax.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).