From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
To: Vidya Sagar <vidyas@nvidia.com>
Cc: Tian Tao <tiantao6@hisilicon.com>,
p.zabel@pengutronix.de, lorenzo.pieralisi@arm.com,
bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v2] PCI: tegra: move to use request_irq by IRQF_NO_AUTOEN flag
Date: Sat, 26 Jun 2021 22:48:43 +0200 [thread overview]
Message-ID: <YNeSq7HcQOBza0x6@qmqm.qmqm.pl> (raw)
In-Reply-To: <78dd0d27-aca7-9d99-a79d-8587a2fbbbfb@nvidia.com>
On Mon, May 31, 2021 at 03:32:33PM +0530, Vidya Sagar wrote:
> I want to re-examine this patch.
> I don't see any references in the kernel where IRQ_NOAUTOEN is passed
> directly in request_irq APIs. It is always set explicitly through
> irq_set_status_flags() *before* calling request_irq APIs.
[...]
The request_irq() flag is called IRQF_NO_AUTOEN. As far as I can read
the cod, it does seem equivalent to changing irq_settings. I'm not sure
why we have two methods to do this in the kernel, though.
Hope that helps.
Best Regards
Michał Mirosław
prev parent reply other threads:[~2021-06-26 20:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 1:12 [PATCH v2] PCI: tegra: move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
2021-05-17 10:17 ` Vidya Sagar
2021-05-31 10:02 ` Vidya Sagar
2021-06-23 9:45 ` Lorenzo Pieralisi
2021-06-23 12:27 ` Bjorn Helgaas
2021-06-26 20:48 ` Michał Mirosław [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNeSq7HcQOBza0x6@qmqm.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=p.zabel@pengutronix.de \
--cc=tiantao6@hisilicon.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).