From: Christoph Hellwig <hch@infradead.org>
To: Uwe Kleine-K??nig <u.kleine-koenig@pengutronix.de>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pci@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v3 2/8] PCI: Drop useless check from pci_device_probe()
Date: Thu, 12 Aug 2021 07:46:39 +0100 [thread overview]
Message-ID: <YRTDz4V82WVnO5tF@infradead.org> (raw)
In-Reply-To: <20210811080637.2596434-3-u.kleine-koenig@pengutronix.de>
On Wed, Aug 11, 2021 at 10:06:31AM +0200, Uwe Kleine-K??nig wrote:
> When the device core calls the probe callback for a device the device is
> never bound and so !pci_dev->driver is always true.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-08-12 6:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 8:06 [PATCH v3 0/8] PCI: Drop duplicated tracking of a pci_dev's bound driver Uwe Kleine-König
2021-08-11 8:06 ` [PATCH v3 1/8] PCI: Simplify pci_device_remove() Uwe Kleine-König
2021-08-12 6:44 ` Christoph Hellwig
2021-08-11 8:06 ` [PATCH v3 2/8] PCI: Drop useless check from pci_device_probe() Uwe Kleine-König
2021-08-12 6:46 ` Christoph Hellwig [this message]
2021-08-11 8:06 ` [PATCH v3 3/8] xen/pci: Drop some checks that are always true Uwe Kleine-König
2021-08-11 9:51 ` Uwe Kleine-König
2021-08-12 6:50 ` Christoph Hellwig
2021-08-11 8:06 ` [PATCH v3 4/8] PCI: replace pci_dev::driver usage that gets the driver name Uwe Kleine-König
2021-08-12 7:07 ` Christoph Hellwig
2021-08-12 8:14 ` Uwe Kleine-König
2021-08-14 8:38 ` Christoph Hellwig
2021-08-11 8:06 ` [PATCH v3 5/8] scsi: message: fusion: Remove unused parameter of mpt_pci driver's probe() Uwe Kleine-König
2021-08-12 2:51 ` Martin K. Petersen
2021-08-12 7:10 ` Christoph Hellwig
2021-08-11 8:06 ` [PATCH v3 6/8] crypto: qat - simplify adf_enable_aer() Uwe Kleine-König
2021-08-11 11:56 ` Giovanni Cabiddu
2021-08-11 21:34 ` Uwe Kleine-König
2021-08-12 14:43 ` Giovanni Cabiddu
2021-08-13 8:15 ` Uwe Kleine-König
2021-08-11 8:06 ` [PATCH v3 7/8] PCI: Replace pci_dev::driver usage by pci_dev::dev.driver Uwe Kleine-König
2021-08-11 14:07 ` Boris Ostrovsky
2021-08-11 8:06 ` [PATCH v3 8/8] PCI: Drop duplicated tracking of a pci_dev's bound driver Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRTDz4V82WVnO5tF@infradead.org \
--to=hch@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-pci@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).