From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44F8EC4338F for ; Sat, 14 Aug 2021 08:24:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 152A160EE4 for ; Sat, 14 Aug 2021 08:24:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237526AbhHNIZV (ORCPT ); Sat, 14 Aug 2021 04:25:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:53620 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237401AbhHNIZV (ORCPT ); Sat, 14 Aug 2021 04:25:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E1FF160EE2; Sat, 14 Aug 2021 08:24:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628929493; bh=Cfglcap9UZcx9wX6xKYoZqz19Fj5k5vI6Kkv/t63bcc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PFOl3ekhuAWp//OuaV7Ll1WAiurWd9WCi2VYoaNzWtTerRyFrPYyvFKh0mXhMqqKv UbvZ52LqOa1k+6pLuJZY+tzTtGxQiLlaWMcIydv/JrYNuHvTdxzhXZfFAAuG0asx6r w1loc7s7qITMXX2Sp4zG5E3jUXZl1R9Gr76mbjPA= Date: Sat, 14 Aug 2021 10:24:50 +0200 From: Greg KH To: Barry Song <21cnbao@gmail.com> Cc: bhelgaas@google.com, corbet@lwn.net, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, mchehab+huawei@kernel.org, Jonathan.Cameron@huawei.com, leon@kernel.org, schnelle@linux.ibm.com, bilbao@vt.edu, luzmaximilian@gmail.com, linuxarm@huawei.com, Barry Song Subject: Re: [PATCH] PCI/MSI: Clarify the irq sysfs ABI for PCI devices Message-ID: References: <20210813122650.25764-1-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210813122650.25764-1-21cnbao@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Sat, Aug 14, 2021 at 12:26:50AM +1200, Barry Song wrote: > From: Barry Song > > /sys/bus/pci/devices/.../irq has been there for many years but it has never > been documented. This patch is trying to document it. Plus, irq ABI is very > confusing at this moment especially for MSI and MSI-x cases. MSI sets irq > to the first number in the vector, but MSI-X does nothing for this though > it saves default_irq in msix_setup_entries(). Weird the saved default_irq > for MSI-X is never used in pci_msix_shutdown(), which is quite different > with pci_msi_shutdown(). Thus, this patch also moves to show the first IRQ > number which is from the first msi_entry for MSI-X. Hopefully, this can > make irq ABI more clear and more consistent. > > Signed-off-by: Barry Song > --- > Documentation/ABI/testing/sysfs-bus-pci | 8 ++++++++ > drivers/pci/msi.c | 6 ++++++ > 2 files changed, 14 insertions(+) Acked-by: Greg Kroah-Hartman