From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 125FEC433FE for ; Wed, 8 Dec 2021 18:43:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239203AbhLHSqf (ORCPT ); Wed, 8 Dec 2021 13:46:35 -0500 Received: from sin.source.kernel.org ([145.40.73.55]:48944 "EHLO sin.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232201AbhLHSqe (ORCPT ); Wed, 8 Dec 2021 13:46:34 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 16685CE22BB; Wed, 8 Dec 2021 18:43:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6392BC00446; Wed, 8 Dec 2021 18:42:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1638988979; bh=+GpKf9l7BzP6NdY/mbki5TrzXMK1vfBAQx1RiiUBRGs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Jdc13FjeeX8BpZb6nsOcLCUCJwDlxBZG6t281Q+dw35ywaq5kYi9Ouad8lWtbX0FQ 1haIaJE7WJHZb17vLnuP6xZ2elPg+rc+pSkQ/05cJbvJQNOjWidKxXZ0bq1mOxI1T6 LU6ieOMB/d+Eoo0wVw8OmRFOxC4PQrxpjdkPT/uA= Date: Wed, 8 Dec 2021 19:42:56 +0100 From: Greg KH To: "David E. Box" Cc: lee.jones@linaro.org, hdegoede@redhat.com, bhelgaas@google.com, andriy.shevchenko@linux.intel.com, srinivas.pandruvada@intel.com, mgross@linux.intel.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-pci@vger.kernel.org, Mark Gross Subject: Re: [PATCH RESEND V2 4/6] platform/x86: Add Intel Software Defined Silicon driver Message-ID: References: <20211208015015.891275-1-david.e.box@linux.intel.com> <20211208015015.891275-5-david.e.box@linux.intel.com> <7701e96d6063b3763eb2b893c059b070ab7b8cd0.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7701e96d6063b3763eb2b893c059b070ab7b8cd0.camel@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Dec 08, 2021 at 10:30:27AM -0800, David E. Box wrote: > On Wed, 2021-12-08 at 19:12 +0100, Greg KH wrote: > > On Wed, Dec 08, 2021 at 09:49:36AM -0800, David E. Box wrote: > > > On Wed, 2021-12-08 at 17:24 +0100, Greg KH wrote: > > > > On Tue, Dec 07, 2021 at 05:50:13PM -0800, David E. Box wrote: > > > > > Intel Software Defined Silicon (SDSi) is a post manufacturing mechanism for > > > > > activating additional silicon features. Features are enabled through a > > > > > license activation process.  The SDSi driver provides a per socket, sysfs > > > > > attribute interface for applications to perform 3 main provisioning > > > > > functions: > > > > > > > > > > 1. Provision an Authentication Key Certificate (AKC), a key written to > > > > >    internal NVRAM that is used to authenticate a capability specific > > > > >    activation payload. > > > > > > > > > > 2. Provision a Capability Activation Payload (CAP), a token authenticated > > > > >    using the AKC and applied to the CPU configuration to activate a new > > > > >    feature. > > > > > > > > > > 3. Read the SDSi State Certificate, containing the CPU configuration > > > > >    state. > > > > > > > > > > The operations perform function specific mailbox commands that forward the > > > > > requests to SDSi hardware to perform authentication of the payloads and > > > > > enable the silicon configuration (to be made available after power > > > > > cycling). > > > > > > > > > > The SDSi device itself is enumerated as an auxiliary device from the > > > > > intel_vsec driver and as such has a build dependency on CONFIG_INTEL_VSEC. > > > > > > > > > > Link: https://github.com/intel/intel-sdsi > > > > > > > > There is no code at this link :( > > > > > > > > > > Not yet. It's currently just documentation. But sample code was added to this patch series. > > > > Is the sample code "real" and what you are going to use for this api? > > It's real in that it could be used to provision real certificates on a production system. Great, so it's all you need, you should move it to tools/ and be done with it! :) thanks, greg k-h