From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Stanimir Varbanov <svarbanov@mm-sol.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Krzysztof Wilczy??ski <kw@linux.com>,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-phy@lists.infradead.org
Subject: Re: [PATCH v5 3/5] PCI: qcom: Add ddrss_sf_tbu flag
Date: Thu, 3 Feb 2022 07:52:27 -0800 [thread overview]
Message-ID: <Yfv6Oyk19xonWX33@ripper> (raw)
In-Reply-To: <20211218141024.500952-4-dmitry.baryshkov@linaro.org>
On Sat 18 Dec 06:10 PST 2021, Dmitry Baryshkov wrote:
> Qualcomm PCIe driver uses compatible string to check if the ddrss_sf_tbu
> clock should be used. Since sc7280 support has added flags, switch to
> the new mechanism to check if this clock should be used.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/pci/controller/dwc/pcie-qcom.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
> index 1204011c96ee..d8d400423a0a 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom.c
> @@ -191,6 +191,7 @@ struct qcom_pcie_ops {
> struct qcom_pcie_cfg {
> const struct qcom_pcie_ops *ops;
> unsigned int pipe_clk_need_muxing:1;
> + unsigned int has_ddrss_sf_tbu_clk:1;
> };
>
> struct qcom_pcie {
> @@ -1133,7 +1134,7 @@ static int qcom_pcie_get_resources_2_7_0(struct qcom_pcie *pcie)
> res->clks[3].id = "bus_slave";
> res->clks[4].id = "slave_q2a";
> res->clks[5].id = "tbu";
> - if (of_device_is_compatible(dev->of_node, "qcom,pcie-sm8250")) {
> + if (pcie->cfg->has_ddrss_sf_tbu_clk) {
> res->clks[6].id = "ddrss_sf_tbu";
> res->num_clks = 7;
> } else {
> @@ -1449,6 +1450,7 @@ static const struct qcom_pcie_cfg sdm845_cfg = {
>
> static const struct qcom_pcie_cfg sm8250_cfg = {
> .ops = &ops_1_9_0,
> + .has_ddrss_sf_tbu_clk = true,
> };
>
> static const struct qcom_pcie_cfg sc7280_cfg = {
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-02-03 15:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-18 14:10 [PATCH v5 0/5] qcom: add support for PCIe on SM8450 platform Dmitry Baryshkov
2021-12-18 14:10 ` [PATCH v5 1/5] dt-bindings: pci: qcom: Document PCIe bindings for SM8450 Dmitry Baryshkov
2021-12-21 14:59 ` Rob Herring
2021-12-21 15:43 ` Dmitry Baryshkov
2021-12-21 19:52 ` Rob Herring
2021-12-21 21:09 ` Dmitry Baryshkov
2021-12-21 23:35 ` Rob Herring
2022-02-03 17:11 ` Bjorn Andersson
2021-12-18 14:10 ` [PATCH v5 2/5] PCI: qcom: Remove redundancy between qcom_pcie and qcom_pcie_cfg Dmitry Baryshkov
2022-02-03 15:47 ` Bjorn Andersson
2021-12-18 14:10 ` [PATCH v5 3/5] PCI: qcom: Add ddrss_sf_tbu flag Dmitry Baryshkov
2022-02-03 15:52 ` Bjorn Andersson [this message]
2021-12-18 14:10 ` [PATCH v5 4/5] PCI: qcom: Add interconnect support to 2.7.0/1.9.0 ops Dmitry Baryshkov
2022-02-03 15:57 ` Bjorn Andersson
2022-02-04 14:38 ` Dmitry Baryshkov
2022-02-11 16:12 ` Lorenzo Pieralisi
2022-02-22 23:47 ` Bjorn Andersson
2022-02-23 9:31 ` Lorenzo Pieralisi
2022-02-23 10:15 ` Dmitry Baryshkov
2022-02-22 23:46 ` Bjorn Andersson
2022-02-22 23:49 ` Bjorn Andersson
2022-02-23 8:37 ` Dmitry Baryshkov
2021-12-18 14:10 ` [PATCH v5 5/5] PCI: qcom: Add SM8450 PCIe support Dmitry Baryshkov
2022-02-03 17:10 ` Bjorn Andersson
2022-02-03 11:54 ` [PATCH v5 0/5] qcom: add support for PCIe on SM8450 platform Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yfv6Oyk19xonWX33@ripper \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kishon@ti.com \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh+dt@kernel.org \
--cc=svarbanov@mm-sol.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).