From: Christoph Hellwig <hch@infradead.org>
To: "David E. Box" <david.e.box@linux.intel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
nirmal.patel@linux.intel.com, jonathan.derrick@linux.dev,
lorenzo.pieralisi@arm.com, kw@linux.com, robh@kernel.org,
bhelgaas@google.com, michael.a.bottini@linux.intel.com,
rafael@kernel.org, me@adhityamohan.in, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V6 1/3] PCI/ASPM: Add pci_enable_default_link_state()
Date: Tue, 1 Mar 2022 05:38:23 -0800 [thread overview]
Message-ID: <Yh4hzz/IGS8xg3vV@infradead.org> (raw)
In-Reply-To: <ba9128b499b243f5c08f855018a37cd1484211b6.camel@linux.intel.com>
On Tue, Mar 01, 2022 at 05:31:51AM -0800, David E. Box wrote:
> > Is there any reason the ASPM_* values aren't passed directly to this
> > function?
>
> The ASPM_* macors aren't visible outside of aspm.c whereas the
> PCIE_LINK_STATE_* macros are defined in pci.h. This is similar to what
> is done for pci_disable_link_state().
Ok. This looks a little weird but I guess we should stick to the
existing pattern here.
next prev parent reply other threads:[~2022-03-01 13:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 4:19 [PATCH V6 0/3] PCI: vmd: Enable PCIe ASPM and LTR David E. Box
2022-03-01 4:19 ` [PATCH V6 1/3] PCI/ASPM: Add pci_enable_default_link_state() David E. Box
2022-03-01 8:13 ` Christoph Hellwig
2022-03-01 13:31 ` David E. Box
2022-03-01 13:38 ` Christoph Hellwig [this message]
2022-08-26 9:16 ` Lorenzo Pieralisi
2022-08-26 17:01 ` Bjorn Helgaas
2022-03-01 4:19 ` [PATCH V6 2/3] PCI: vmd: Add vmd_device_data David E. Box
2022-08-26 9:15 ` Lorenzo Pieralisi
2022-03-01 4:19 ` [PATCH V6 3/3] PCI: vmd: Configure PCIe ASPM and LTR David E. Box
2022-08-26 17:01 ` Bjorn Helgaas
2022-09-14 20:59 ` David E. Box
2022-03-01 19:19 ` [PATCH V6 0/3] PCI: vmd: Enable " Jonathan Derrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh4hzz/IGS8xg3vV@infradead.org \
--to=hch@infradead.org \
--cc=bhelgaas@google.com \
--cc=david.e.box@linux.intel.com \
--cc=jonathan.derrick@linux.dev \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=me@adhityamohan.in \
--cc=michael.a.bottini@linux.intel.com \
--cc=nirmal.patel@linux.intel.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).