From: Boqun Feng <boqun.feng@gmail.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com,
bhelgaas@google.com, linux-hyperv@vger.kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] PCI: hv: Remove unused function hv_set_msi_entry_from_desc()
Date: Thu, 17 Mar 2022 22:03:59 +0800 [thread overview]
Message-ID: <YjM/z4vlPlVhdfMu@boqun-archlinux> (raw)
In-Reply-To: <20220317085130.36388-1-yuehaibing@huawei.com>
On Thu, Mar 17, 2022 at 04:51:30PM +0800, YueHaibing wrote:
> This patch fix the following build error:
>
> drivers/pci/controller/pci-hyperv.c:769:13: error: ‘hv_set_msi_entry_from_desc’ defined but not used [-Werror=unused-function]
> 769 | static void hv_set_msi_entry_from_desc(union hv_msi_entry *msi_entry,
>
> On arm64 hv_set_msi_entry_from_desc() is not used anymore since
> commit d06957d7a692 ("PCI: hv: Avoid the retarget interrupt hypercall in irq_unmask() on ARM64").
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Good catch!
Acked-by: Boqun Feng <boqun.feng@gmail.com>
Regards,
Boqun
> ---
> drivers/pci/controller/pci-hyperv.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> index df84d221e3de..558b35aba610 100644
> --- a/drivers/pci/controller/pci-hyperv.c
> +++ b/drivers/pci/controller/pci-hyperv.c
> @@ -766,14 +766,6 @@ static unsigned int hv_msi_get_int_vector(struct irq_data *irqd)
> return irqd->parent_data->hwirq;
> }
>
> -static void hv_set_msi_entry_from_desc(union hv_msi_entry *msi_entry,
> - struct msi_desc *msi_desc)
> -{
> - msi_entry->address = ((u64)msi_desc->msg.address_hi << 32) |
> - msi_desc->msg.address_lo;
> - msi_entry->data = msi_desc->msg.data;
> -}
> -
> /*
> * @nr_bm_irqs: Indicates the number of IRQs that were allocated from
> * the bitmap.
> --
> 2.17.1
>
next prev parent reply other threads:[~2022-03-17 14:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 8:51 [PATCH -next] PCI: hv: Remove unused function hv_set_msi_entry_from_desc() YueHaibing
2022-03-17 14:03 ` Boqun Feng [this message]
2022-03-26 20:12 ` Nathan Chancellor
2022-03-29 23:30 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjM/z4vlPlVhdfMu@boqun-archlinux \
--to=boqun.feng@gmail.com \
--cc=bhelgaas@google.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kw@linux.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).