From: Rob Herring <robh@kernel.org>
To: Jiantao Zhang <water.zhangjiantao@huawei.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
"jingoohan1@gmail.com" <jingoohan1@gmail.com>,
"gustavo.pimentel@synopsys.com" <gustavo.pimentel@synopsys.com>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"kw@linux.com" <kw@linux.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"zhangjianrong (E)" <zhangjianrong5@huawei.com>,
caiyadong <caiyadong@huawei.com>,
"xuetao (kirin)" <xuetao09@huawei.com>,
xuhaiyang <xuhaiyang5@hisilicon.com>,
songxiaowei@hisilicon.com, guhengsheng@hisilicon.com
Subject: Re: [PATCH v2] PCI: dwc: Fix setting error return on MSI DMA mapping failure
Date: Thu, 24 Mar 2022 16:04:14 -0500 [thread overview]
Message-ID: <Yjzczp4SX3CPdKM8@robh.at.kernel.org> (raw)
In-Reply-To: <30170911-0e2f-98ce-9266-70465b9073e5@huawei.com>
On Wed, Mar 09, 2022 at 08:01:04PM +0800, Jiantao Zhang wrote:
> When dma_mapping_error() returns error because of no enough memory,
> but dw_pcie_host_init() returns success, which will mislead the callers.
>
> Fixes: 07940c369a6b ("PCI: dwc: Fix MSI page leakage in suspend/resume")
> Signed-off-by: Jianrong Zhang <zhangjianrong5@huawei.com>
> Signed-off-by: Jiantao Zhang <water.zhangjiantao@huawei.com>
> ---
> drivers/pci/controller/dwc/pcie-designware-host.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2022-03-24 21:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 15:45 [PATCH2] PCI: dwc: solve returning success but actually failed Zhangjiantao(Kirin,Nanjing)
2022-03-08 17:03 ` Rob Herring
2022-03-09 12:01 ` [PATCH v2] PCI: dwc: Fix setting error return on MSI DMA mapping failure Jiantao Zhang
2022-03-24 21:04 ` Rob Herring [this message]
2022-04-08 14:43 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yjzczp4SX3CPdKM8@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=caiyadong@huawei.com \
--cc=guhengsheng@hisilicon.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=helgaas@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=songxiaowei@hisilicon.com \
--cc=water.zhangjiantao@huawei.com \
--cc=xuetao09@huawei.com \
--cc=xuhaiyang5@hisilicon.com \
--cc=zhangjianrong5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).