Re: [PATCH 0/5] Add support for Axis, ARTPEC-8 PCIe driver

From: Vinod Koul <vkoul@kernel.org>
To: Wangseok Lee <wangseok.lee@samsung.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	robh+dt <robh+dt@kernel.org>, krzk+dt <krzk+dt@kernel.org>,
	kishon <kishon@ti.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"jesper.nilsson" <jesper.nilsson@axis.com>,
	"lars.persson" <lars.persson@axis.com>,
	bhelgaas <bhelgaas@google.com>,
	linux-phy <linux-phy@lists.infradead.org>,
	linux-pci <linux-pci@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	"lorenzo.pieralisi" <lorenzo.pieralisi@arm.com>,
	kw <kw@linux.com>, linux-arm-kernel <linux-arm-kernel@axis.com>,
	kernel <kernel@axis.com>, Moon-Ki Jun <moonki.jun@samsung.com>,
	Dongjin Yang <dj76.yang@samsung.com>
Subject: Re: [PATCH 0/5] Add support for Axis, ARTPEC-8 PCIe driver
Date: Mon, 2 May 2022 15:44:15 +0530	[thread overview]
Message-ID: <Ym+u9yYrV9mxkyWX@matsya> (raw)
In-Reply-To: <20220421235725epcms2p1fc34c904f960cba958fa692c6d5dad9c@epcms2p1>

On 22-04-22, 08:57, Wangseok Lee wrote:
> > On 18/04/2022 09:20, Wangseok Lee wrote:

> > Maybe, quite probably. The reluctance to extend any existing code makes
> > me doubting this, but I admit that there are many differences.
> > 
> >> For these reasons, my opinion is that better to create
> >> a phy, controller both driver with a new file.
> >> Please let me know your opinion.
> > 
> > At the end it's mostly the decision of PCIe and phy subsystem
> > maintainers whether they want to have separate drivers for DWC PCIe
> > blocks in ARMv8 Samsung SoCs.
> > 
> > In any case, the driver code looks like copied-pasted from some vendor
> > sources, so you need to bring it to shape.

I think havong a common driver helps everyone, many vendors do that
already. If you have a technical issue of adding and maintaining a
common driver upstream we would be eager to understand and help with
that...

-- 
~Vinod