From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Frank Li <Frank.Li@nxp.com>, Rob Herring <robh@kernel.org>,
Vinod Koul <vkoul@kernel.org>,
gustavo.pimentel@synopsys.com, hongxing.zhu@nxp.com,
l.stach@pengutronix.de, linux-imx@nxp.com,
linux-pci@vger.kernel.org, dmaengine@vger.kernel.org,
lznuaa@gmail.com, helgaas@kernel.org, kw@linux.com,
bhelgaas@google.com, manivannan.sadhasivam@linaro.org,
Sergey.Semin@baikalelectronics.ru
Subject: Re: [PATCH v10 0/9] Enable designware PCI EP EDMA locally
Date: Tue, 10 May 2022 18:47:49 +0100 [thread overview]
Message-ID: <YnqlRShJzvma2SKM@lpieralisi> (raw)
In-Reply-To: <20220503231806.w2x4o2b3xymbwn74@mobilestation>
On Wed, May 04, 2022 at 02:18:06AM +0300, Serge Semin wrote:
> On Mon, May 02, 2022 at 07:57:52PM -0500, Frank Li wrote:
> > Default Designware EDMA just probe remotely at host side.
> > This patch allow EDMA driver can probe at EP side.
> >
> > 1. Clean up patch
> > dmaengine: dw-edma: Detach the private data and chip info structures
> > dmaengine: dw-edma: Remove unused field irq in struct dw_edma_chip
> > dmaengine: dw-edma: Change rg_region to reg_base in struct
> > dmaengine: dw-edma: rename wr(rd)_ch_cnt to ll_wr(rd)_cnt in struct
> >
> > 2. Enhance EDMA driver to allow prode eDMA at EP side
> > dmaengine: dw-edma: Add support for chip specific flags
> > dmaengine: dw-edma: Add DW_EDMA_CHIP_32BIT_DBI for chip specific flags
> >
> > 3. Bugs fix at EDMA driver when probe eDMA at EP side
> > dmaengine: dw-edma: Fix programming the source & dest addresses for ep
> > dmaengine: dw-edma: Don't rely on the deprecated "direction" member
> >
> > 4. change pci-epf-test to use EDMA driver to transfer data.
> > PCI: endpoint: Add embedded DMA controller test
> >
> > 5. Using imx8dxl to do test, but some EP functions still have not
> > upstream yet. So below patch show how probe eDMA driver at EP
> > controller driver.
> > https://lore.kernel.org/linux-pci/20220309120149.GB134091@thinkpad/T/#m979eb506c73ab3cfca2e7a43635ecdaec18d8097
>
> As I have already said in my comment to v9, @Lorenzo, @Rob, @Vinod,
> my patchset:
> Link: https://lore.kernel.org/linux-pci/20220503225104.12108-1-Sergey.Semin@baikalelectronics.ru
> is based on this one. In its turn my series depends on the other
> patchsets:
> [PATCH v3 0/4] clk: Baikal-T1 DDR/PCIe resets and some xGMAC fixes
> Link: https://lore.kernel.org/linux-pci/20220503205722.24755-1-Sergey.Semin@baikalelectronics.ru/
> [PATCH v2 00/13] PCI: dwc: Various fixes and cleanups
> Link: https://lore.kernel.org/linux-pci/20220503212300.30105-1-Sergey.Semin@baikalelectronics.ru/
> [PATCH v2 00/17] PCI: dwc: Add dma-ranges/YAML-schema/Baikal-T1 support
> Link: https://lore.kernel.org/linux-pci/20220503214638.1895-1-Sergey.Semin@baikalelectronics.ru/
> which are currently on review. I am very much eager to get my patches
> merged in before the next merge windows. But in order to preserve the
> consistency of the corresponding repo with my patchsets the repo needs
> to have the @Frank' patches. Seeing aside with @Frank's series my changes
> depend on the changes in the clk and pci subsystems, could you please
> consider choosing a single repository for merging all my and @Frank
> patches in? Since the changes mostly concern the DW PCIe controller I
> suggest to use the 'pci/dwc' branch of the
> 'kernel/git/lpieralisi/pci.git' repository. What do you think?
> @Lorenzo?
>
Sorry for the delay in replying. I think @Frank's series will
go via the DMA engine tree, I will do my best to review your
DWC changes:
[PATCH v2 00/13] PCI: dwc: Various fixes and cleanups
Link: https://lore.kernel.org/linux-pci/20220503212300.30105-1-Sergey.Semin@baikalelectronics.ru/
but I can't guarantee they will make v5.19 and after that I will
be AFK for two months, which is not good either, I will coordinate
with Bjorn to see what can we do on this, I am sorry but that's
all I have to offer at this stage.
Thanks,
Lorenzo
> -Sergey
>
> >
> >
> > Frank Li (7):
> > dmaengine: dw-edma: Remove unused field irq in struct dw_edma_chip
> > dmaengine: dw-edma: Detach the private data and chip info structures
> > dmaengine: dw-edma: Change rg_region to reg_base in struct
> > dw_edma_chip
> > dmaengine: dw-edma: Rename wr(rd)_ch_cnt to ll_wr(rd)_cnt in struct
> > dw_edma_chip
> > dmaengine: dw-edma: Add support for chip specific flags
> > dmaengine: dw-edma: Add DW_EDMA_CHIP_32BIT_DBI for chip specific flags
> > PCI: endpoint: Enable DMA controller tests for endpoints with DMA
> > capabilities
> >
> > Serge Semin (2):
> > dmaengine: dw-edma: Drop dma_slave_config.direction field usage
> > dmaengine: dw-edma: Fix eDMA Rd/Wr-channels and DMA-direction
> > semantics
> >
> > drivers/dma/dw-edma/dw-edma-core.c | 141 +++++++++++-------
> > drivers/dma/dw-edma/dw-edma-core.h | 31 +---
> > drivers/dma/dw-edma/dw-edma-pcie.c | 83 +++++------
> > drivers/dma/dw-edma/dw-edma-v0-core.c | 54 ++++---
> > drivers/dma/dw-edma/dw-edma-v0-core.h | 4 +-
> > drivers/dma/dw-edma/dw-edma-v0-debugfs.c | 18 +--
> > drivers/dma/dw-edma/dw-edma-v0-debugfs.h | 8 +-
> > drivers/pci/endpoint/functions/pci-epf-test.c | 108 ++++++++++++--
> > include/linux/dma/edma.h | 61 +++++++-
> > 9 files changed, 323 insertions(+), 185 deletions(-)
> >
> > --
> > 2.35.1
> >
next prev parent reply other threads:[~2022-05-10 17:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 0:57 [PATCH v10 0/9] Enable designware PCI EP EDMA locally Frank Li
2022-05-03 0:57 ` [PATCH v10 1/9] dmaengine: dw-edma: Remove unused field irq in struct dw_edma_chip Frank Li
2022-05-03 0:57 ` [PATCH v10 2/9] dmaengine: dw-edma: Detach the private data and chip info structures Frank Li
2022-05-03 0:57 ` [PATCH v10 3/9] dmaengine: dw-edma: Change rg_region to reg_base in struct dw_edma_chip Frank Li
2022-05-03 0:57 ` [PATCH v10 4/9] dmaengine: dw-edma: Rename wr(rd)_ch_cnt to ll_wr(rd)_cnt " Frank Li
2022-05-03 0:57 ` [PATCH v10 5/9] dmaengine: dw-edma: Drop dma_slave_config.direction field usage Frank Li
2022-05-03 0:57 ` [PATCH v10 6/9] dmaengine: dw-edma: Fix eDMA Rd/Wr-channels and DMA-direction semantics Frank Li
2022-05-03 0:57 ` [PATCH v10 7/9] dmaengine: dw-edma: Add support for chip specific flags Frank Li
2022-05-03 0:58 ` [PATCH v10 8/9] dmaengine: dw-edma: Add DW_EDMA_CHIP_32BIT_DBI " Frank Li
2022-05-04 18:43 ` Zhi Li
2022-05-03 0:58 ` [PATCH v10 9/9] PCI: endpoint: Enable DMA controller tests for endpoints with DMA capabilities Frank Li
2022-05-04 19:34 ` Zhi Li
2022-05-11 9:28 ` Lorenzo Pieralisi
2022-05-11 16:18 ` Zhi Li
2022-05-11 17:30 ` Lorenzo Pieralisi
2022-05-11 19:12 ` Zhi Li
2022-05-13 0:48 ` Zhi Li
2022-05-12 13:51 ` Kishon Vijay Abraham I
2022-05-12 15:36 ` Zhi Li
2022-05-03 23:18 ` [PATCH v10 0/9] Enable designware PCI EP EDMA locally Serge Semin
2022-05-10 17:47 ` Lorenzo Pieralisi [this message]
2022-05-10 18:02 ` Zhi Li
2022-05-12 0:04 ` Serge Semin
2022-05-12 14:14 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnqlRShJzvma2SKM@lpieralisi \
--to=lorenzo.pieralisi@arm.com \
--cc=Frank.Li@nxp.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=bhelgaas@google.com \
--cc=dmaengine@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=helgaas@kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=kw@linux.com \
--cc=l.stach@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-pci@vger.kernel.org \
--cc=lznuaa@gmail.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).