From: Daniel Vetter <daniel@ffwll.ch>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Helge Deller <deller@gmx.de>,
linux-fbdev@vger.kernel.org, linux-pm@vger.kernel.org,
linux-pci@vger.kernel.org,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Vaibhav Gupta <vaibhavgupta40@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH 0/2] video: fbdev: Convert from PCI to generic power management
Date: Wed, 8 Jun 2022 18:26:34 +0200 [thread overview]
Message-ID: <YqDNuhopLfpHkTS7@phenom.ffwll.local> (raw)
In-Reply-To: <20220607231112.354165-1-helgaas@kernel.org>
On Tue, Jun 07, 2022 at 06:11:10PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> PCI-specific power management (pci_driver.suspend and pci_driver.resume) is
> deprecated. If drivers implement power management, they should use the
> generic power management framework, not the PCI-specific hooks.
>
> No fbdev drivers actually implement PCI power management, but there are a
> cirrusfb has some commented-out references to it and skeletonfb has
> examples of it. Remove these.
Is this holding up some cleanup on your side and so would be easier to
merge these through the pci tree? If so
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
for merging through your tree. Otherwise I guess Helge will get around to
pile them up for 5.20 (or 6.0) eventually.
Cheers, Daniel
>
> Bjorn Helgaas (2):
> video: fbdev: cirrusfb: Remove useless reference to PCI power
> management
> video: fbdev: skeletonfb: Convert to generic power management
>
> drivers/video/fbdev/cirrusfb.c | 6 ------
> drivers/video/fbdev/skeletonfb.c | 13 +++++++------
> 2 files changed, 7 insertions(+), 12 deletions(-)
>
> --
> 2.25.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2022-06-08 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 23:11 [PATCH 0/2] video: fbdev: Convert from PCI to generic power management Bjorn Helgaas
2022-06-07 23:11 ` [PATCH 1/2] video: fbdev: cirrusfb: Remove useless reference to PCI " Bjorn Helgaas
2022-06-07 23:11 ` [PATCH 2/2] video: fbdev: skeletonfb: Convert to generic " Bjorn Helgaas
2022-06-08 16:26 ` Daniel Vetter [this message]
2022-06-08 18:09 ` [PATCH 0/2] video: fbdev: Convert from PCI " Bjorn Helgaas
2022-06-20 12:40 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqDNuhopLfpHkTS7@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=bhelgaas@google.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=helgaas@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=vaibhavgupta40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).