From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90551C433EF for ; Thu, 14 Jul 2022 14:27:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238638AbiGNO1m (ORCPT ); Thu, 14 Jul 2022 10:27:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240397AbiGNO1d (ORCPT ); Thu, 14 Jul 2022 10:27:33 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2B4485E32F for ; Thu, 14 Jul 2022 07:27:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657808852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RNJXv/KlGONTEw9UXAEACL1ZXePk/fcM/JbeLsfKXUw=; b=SfEQoZ8oI+2U5hAsIOqttiExWdS/srUqkpOatosNqACOpFyXiM/BabtTVDaorLk4yAE2cx 8NXBQYANYZSaMz/NFiN/lyDICxtb5VHFAQvuO4rvsYG/H2Vh7PCwv7If5ZT4RFvgHe7Zpd mh4hffXnAUdro+HFxRSaP9MoXEv/JsE= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-556-D_A4_VwiOhaHbjGejvTRkQ-1; Thu, 14 Jul 2022 10:27:25 -0400 X-MC-Unique: D_A4_VwiOhaHbjGejvTRkQ-1 Received: by mail-qt1-f197.google.com with SMTP id d4-20020ac851c4000000b0031eb2c46a9bso1589153qtn.12 for ; Thu, 14 Jul 2022 07:27:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RNJXv/KlGONTEw9UXAEACL1ZXePk/fcM/JbeLsfKXUw=; b=VIA4BoTRv6e0QvOoQyuwONm1YhLXwc4tLN47JQh6kIk+uEfbgTXxg3FbSJs923/o4f i/dEp9EwbDNsjwUX+eAVXcSdkqJafvuK3Yyq8bi7dZ7GjkEEeAaadLqF8HMhYSoB/p+i DpT5R/PqBclhH2J/OR1FC6h7+wZJWn2Vl9s5cIGHxVRbQa3sp8/UejF18OF8ecyndyfU E0RhmURclMo2BRhGS+aqVjFHjGefUTZUwByKsg5AkUbMgvV19MdarXSgZGTXjhI0+UF/ Q/uaRmm4O/ijnJqZG7tVvDv4/iMkK1mtCWGvu3bwT9ZoAUDfVOn5/YXHk6qNFmCH0q35 yqRw== X-Gm-Message-State: AJIora8QZFg3nIMUVs407P5SP2OD6TjZh8WxnRJWdGy1du724KmVCe2K j4U8PZLovPsNjU3E+uGwmg4KcjSXeF96kVn3H2b/s2dqGrlHOwut75YXI2xjPuVMIlxQLpGFZ5l VlNNBdf9YPGGaHwEsqRzn X-Received: by 2002:a05:620a:f89:b0:6ae:d418:f478 with SMTP id b9-20020a05620a0f8900b006aed418f478mr6128528qkn.344.1657808844827; Thu, 14 Jul 2022 07:27:24 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t5up/uVQSQVJGK2rot92yODR4yGOS6QtM36+OI4Q093IbCDbzMZioEvPtNIyYuRZVqtbwvyQ== X-Received: by 2002:a05:620a:f89:b0:6ae:d418:f478 with SMTP id b9-20020a05620a0f8900b006aed418f478mr6128500qkn.344.1657808844567; Thu, 14 Jul 2022 07:27:24 -0700 (PDT) Received: from xps13 (c-98-239-145-235.hsd1.wv.comcast.net. [98.239.145.235]) by smtp.gmail.com with ESMTPSA id r14-20020ac867ce000000b0031eb47652dcsm1534529qtp.59.2022.07.14.07.27.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jul 2022 07:27:24 -0700 (PDT) Date: Thu, 14 Jul 2022 10:27:23 -0400 From: Brian Masney To: Johan Hovold Cc: Bjorn Helgaas , Stanimir Varbanov , Lorenzo Pieralisi , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Dmitry Baryshkov , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 8/8] PCI: qcom: Sort device-id table Message-ID: References: <20220714071348.6792-1-johan+linaro@kernel.org> <20220714071348.6792-9-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220714071348.6792-9-johan+linaro@kernel.org> User-Agent: Mutt/2.2.6 (2022-06-05) Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Jul 14, 2022 at 09:13:48AM +0200, Johan Hovold wrote: > Sort the device-id table entries alphabetically by compatible string to > make it easier to find entries and add new ones. > > Signed-off-by: Johan Hovold > --- > drivers/pci/controller/dwc/pcie-qcom.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index 8dddb72f8647..fea921cca8fa 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -1749,24 +1749,24 @@ static int qcom_pcie_remove(struct platform_device *pdev) > } > > static const struct of_device_id qcom_pcie_match[] = { > + { .compatible = "qcom,pcie-apq8064", .data = &cfg_2_1_0 }, > { .compatible = "qcom,pcie-apq8084", .data = &cfg_1_0_0 }, > + { .compatible = "qcom,pcie-ipq6018", .data = &cfg_2_9_0 }, > { .compatible = "qcom,pcie-ipq8064", .data = &cfg_2_1_0 }, > { .compatible = "qcom,pcie-ipq8064-v2", .data = &cfg_2_1_0 }, > - { .compatible = "qcom,pcie-apq8064", .data = &cfg_2_1_0 }, > - { .compatible = "qcom,pcie-msm8996", .data = &cfg_2_3_2 }, > { .compatible = "qcom,pcie-ipq8074", .data = &cfg_2_3_3 }, > { .compatible = "qcom,pcie-ipq4019", .data = &cfg_2_4_0 }, qcom,pcie-ipq4019 should be moved up above qcom,pcie-ipq6018. Brian