From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F12FCCA47C for ; Fri, 15 Jul 2022 11:35:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229606AbiGOLfT (ORCPT ); Fri, 15 Jul 2022 07:35:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229978AbiGOLfS (ORCPT ); Fri, 15 Jul 2022 07:35:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9B694D831; Fri, 15 Jul 2022 04:35:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 71BBE622EA; Fri, 15 Jul 2022 11:35:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59AEAC34115; Fri, 15 Jul 2022 11:35:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657884910; bh=pYI5okDc37msRqnfKIveqoUw4anLGHg/O2orcG5WOs8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hE7/5KV2bbmzxDhOPC6caMqNbd9vrUqJIV/n8xn4n8tKZMlSPs7RdYc4ftu3Abv8x yh6nvKed9MsWqf9ijpgkvDHE7VL/Z6XRZrR81M/7dvYaMALqvgx+MnKMnnsl5QLWZ1 vFK1fA6f+uBNeZcefuIUzY0nIG54IscpPM4KTJxhbxV8HDSSvLf/K9mgWCcn37Fb9c kJYk1geU1wBRh/SryJpd01dT4VOLUfKH174WLtbdPh5U22SIUt4vwd8QxZyNSWfT9k ix4xLPqdlrB7tWod/Jd8/EVO+TJ4SeDzoD4kLBePAUmm6K93hPgd3RV0lerf9h6rmw ndDKeXIuNLGuQ== Date: Fri, 15 Jul 2022 17:05:07 +0530 From: Vinod Koul To: Marek Szyprowski Cc: linux-pci@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-phy@lists.infradead.org, Jingoo Han , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Krzysztof Kozlowski , Alim Akhtar , Kishon Vijay Abraham I Subject: Re: [PATCH 1/2] phy: samsung: phy-exynos-pcie: sanitize init/power_on callbacks Message-ID: References: <20220628220409.26545-1-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220628220409.26545-1-m.szyprowski@samsung.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 29-06-22, 00:04, Marek Szyprowski wrote: > The exynos-pcie driver called phy_power_on() and then phy_init() for some > historical reasons. However the generic PHY framework assumes that the > proper sequence is to call phy_init() first, then phy_power_on(). The > operations done by both functions should be considered as one action and > as such they are called by the exynos-pcie driver (without doing anything > between them). The initialization is just a sequence of register writes, > which cannot be altered, without breaking the hardware operation. > > To match the generic PHY framework requirement, simply move all register > writes to the phy_init()/phy_exit() and drop power_on()/power_off() > callbacks. This way the driver will also work with the old (incorrect) > PHY initialization call sequence. Acked-By: Vinod Koul -- ~Vinod