From: Jason Gunthorpe <jgg@nvidia.com>
To: Josef Johansson <josef@oderland.se>, Bjorn Helgaas <bhelgaas@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-pci@vger.kernel.org,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] PCI/MSI: Correct use of can_mask in msi_add_msi_desc()
Date: Fri, 5 Aug 2022 09:10:41 -0300 [thread overview]
Message-ID: <Yu0IwZXyTIhdALMb@nvidia.com> (raw)
In-Reply-To: <f1d3ebc5-0e5e-20b5-430c-9426aa5e4bbe@oderland.se>
On Fri, Aug 05, 2022 at 12:03:15PM +0200, Josef Johansson wrote:
> On 2/14/22 11:07, Josef Johansson wrote:
> > From: Josef Johansson <josef@oderland.se>
> >
> > PCI/MSI: Correct use of can_mask in msi_add_msi_desc()
> > Commit 71020a3c0dff4 ("PCI/MSI: Use msi_add_msi_desc()") modifies
> > the logic of checking msi_attrib.can_mask, without any reason.
> > This commits restores that logic.
> >
> > Fixes: 71020a3c0dff4 ("PCI/MSI: Use msi_add_msi_desc()")
> > Signed-off-by: Josef Johansson <josef@oderland.se>
> >
> > ---
> > v2: Changing subject line to fit earlier commits.
> >
> > Trying to fix a NULL BUG in the NVMe MSIX implementation I stumbled upon this code,
> > which ironically was what my last MSI patch resulted into.
> >
> > I don't see any reason why this logic was change, and it did not break anything
> > correcting the logic.
> >
> > CC xen-devel since it very much relates to Xen kernel (via pci_msi_ignore_mask).
> > ---
> >
> > diff --git a/drivers/pci/msi/msi.c b/drivers/pci/msi/msi.c
> > index c19c7ca58186..146e7b9a01cc 100644
> > --- a/drivers/pci/msi/msi.c
> > +++ b/drivers/pci/msi/msi.c
> > @@ -526,7 +526,7 @@ static int msix_setup_msi_descs(struct pci_dev *dev, void __iomem *base,
> > desc.pci.msi_attrib.can_mask = !pci_msi_ignore_mask &&
> > !desc.pci.msi_attrib.is_virtual;
> > - if (!desc.pci.msi_attrib.can_mask) {
> > + if (desc.pci.msi_attrib.can_mask) {
> > addr = pci_msix_desc_addr(&desc);
> > desc.pci.msix_ctrl = readl(addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
> > }
> >
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Bjorn, please take it?
Jason
next prev parent reply other threads:[~2022-08-05 12:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 10:07 [PATCH v2] PCI/MSI: Correct use of can_mask in msi_add_msi_desc() Josef Johansson
2022-08-05 10:03 ` Josef Johansson
2022-08-05 12:10 ` Jason Gunthorpe [this message]
2022-08-05 15:53 ` Bjorn Helgaas
2022-08-26 13:08 ` Jason Gunthorpe
2022-08-26 15:51 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yu0IwZXyTIhdALMb@nvidia.com \
--to=jgg@nvidia.com \
--cc=bhelgaas@google.com \
--cc=josef@oderland.se \
--cc=linux-pci@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).