From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D369C6FD1D for ; Tue, 14 Mar 2023 12:42:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231279AbjCNMmz (ORCPT ); Tue, 14 Mar 2023 08:42:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231602AbjCNMmh (ORCPT ); Tue, 14 Mar 2023 08:42:37 -0400 Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCC941C7FB for ; Tue, 14 Mar 2023 05:42:14 -0700 (PDT) Received: by mail-qv1-xf32.google.com with SMTP id o3so10574471qvr.1 for ; Tue, 14 Mar 2023 05:42:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678797733; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HYpnkGI54FPJWgehk8vQdkx13aLmQ4B3x8mczSXyAME=; b=osjmOZDeLraLaarKa9V5mcSCp9hbIycNSD3yHTrjFhUyAYwdI1i7rMQiTrjR8cZ2od 0DMbmVnXrMNIJoTWaAQrUVapDWE16HpaRHW3cDzBL1on/DXPlAxsO5znqfmOcqHhMtCP qAEWrdxd7QOS/ZQt4PvraSz2ldWHbMpFboa33RXOLH0Wtmg+NZ1raVLGDf0O4VB1Apb1 35AU5D4D2f1unChLmGMBcpHiSDIspARM9gKzXhRUvKOx+Ftk/dt2ALPrtKUoJmaQ5tTf GLtXhviZ13qrSPoyNAl9RqfE3pncOkLTwxQSXheV2cpuxYUmw6BRKYbyxezyNgn8iaNU 8BjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678797733; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HYpnkGI54FPJWgehk8vQdkx13aLmQ4B3x8mczSXyAME=; b=fTBSE4ccfTfutPoCG7iJ0fWOSKAxVG3EbSeuF6m0fMdKy+ZRd0VbciBQz0Jn30i31L HPjIEIS5P5PObNjYbfqAMabGyVH7PrdvcyCGQtZdY2tZrKT+yY/bxCFx1c801qaosYv1 mOQhy57lynugl+fmhME8E/M9uS8o+QyRPztcifKznuaat9xvXrdtq3oJrasFDOv7TJOt 1Gi9wBGoN4fZFONLfhVwn9SYS5AF/79FQaLoRiBohItGNkUDAiVdLKYgyxD3Fk3xjR0M fmdNlgXxO92FK9VBdU8FdHgr1mK/CnuedhD4Fhe425IKzDeIr0U6mW68nvIjgiGi/DCM /idw== X-Gm-Message-State: AO0yUKV6mdTc8Niuow99gmqoeU+Qie67hcrKqjEdphac2UZpuwT476Dw AybkyM9ZYAj/AxuGZqRuoDc1qw== X-Google-Smtp-Source: AK7set9Af5VZ1Oq6MUayK61t3uF8OJyuB9sTGKaVgTfwB7rrZERwp8s4R3FQPjGwsyhnuo2IFnfaaw== X-Received: by 2002:a05:622a:174c:b0:3d3:d291:61b with SMTP id l12-20020a05622a174c00b003d3d291061bmr444136qtk.53.1678797733394; Tue, 14 Mar 2023 05:42:13 -0700 (PDT) Received: from fedora (69-109-179-158.lightspeed.dybhfl.sbcglobal.net. [69.109.179.158]) by smtp.gmail.com with ESMTPSA id s3-20020a37a903000000b00743838d9f49sm1708198qke.12.2023.03.14.05.42.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 05:42:02 -0700 (PDT) Date: Tue, 14 Mar 2023 08:41:59 -0400 From: William Breathitt Gray To: Niklas Schnelle Cc: Arnd Bergmann , Greg Kroah-Hartman , Bjorn Helgaas , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Mauro Carvalho Chehab , Alan Stern , "Rafael J. Wysocki" , Geert Uytterhoeven , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org, Arnd Bergmann , linux-iio@vger.kernel.org Subject: Re: [PATCH v3 05/38] counter: add HAS_IOPORT dependencies Message-ID: References: <20230314121216.413434-1-schnelle@linux.ibm.com> <20230314121216.413434-6-schnelle@linux.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QfXKkWYR1v/wDFbl" Content-Disposition: inline In-Reply-To: <20230314121216.413434-6-schnelle@linux.ibm.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org --QfXKkWYR1v/wDFbl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 14, 2023 at 01:11:43PM +0100, Niklas Schnelle wrote: > In a future patch HAS_IOPORT=3Dn will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them. >=20 > Co-developed-by: Arnd Bergmann > Signed-off-by: Niklas Schnelle > --- > drivers/counter/Kconfig | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig > index b5ba8fb02cf7..1cae5097217e 100644 > --- a/drivers/counter/Kconfig > +++ b/drivers/counter/Kconfig > @@ -15,6 +15,7 @@ if COUNTER > config 104_QUAD_8 > tristate "ACCES 104-QUAD-8 driver" > depends on (PC104 && X86) || COMPILE_TEST > + depends on HAS_IOPORT > select ISA_BUS_API > help > Say yes here to build support for the ACCES 104-QUAD-8 quadrature > --=20 > 2.37.2 Is HAS_IOPORT needed because this driver uses devm_ioport_map()? The inb()/outb() functions and such are not used in this driver, so would it suffice to depend on HAS_IOPORT_MAP instead? William Breathitt Gray --QfXKkWYR1v/wDFbl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZBBrlwAKCRC1SFbKvhIj K3ITAQCwcVYfGAF7Mb2JIBQNeuQ8Hzcy2QcEujfYu0xORFfokwD/dkgs7hwz2zMe 11UPcZMJuttibJDA+MhtxUzdy4+OrQQ= =yKTg -----END PGP SIGNATURE----- --QfXKkWYR1v/wDFbl--