From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B10EDCCA480 for ; Fri, 24 Jun 2022 15:23:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229801AbiFXPXR (ORCPT ); Fri, 24 Jun 2022 11:23:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231207AbiFXPXQ (ORCPT ); Fri, 24 Jun 2022 11:23:16 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3323518E09 for ; Fri, 24 Jun 2022 08:23:14 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id v65-20020a1cac44000000b003a03c76fa38so865888wme.5 for ; Fri, 24 Jun 2022 08:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=iBD6lZMrnBTLHBBN9+Gb5cpKL7uxMI++sU69V4zVy+g=; b=Ak3dZ2Fg/xLBIIyG9LmGzCk2rkzcaNGR952atj0QzMZMbTIGExIe9Rm+vHSGhrCoCA UakSvLfYUy8kHTrhiADloYV88/2nSm0Fr0CqHTe0vuh8Wiq93OV+rHdFug4+1DAjyv42 i3tNodeUujyEPioV1ionUmiWkZN1zhyuVJl4zf7cRfEy2bzRIXRpWbRKiQ2eGuNGaY6r V5eCkVMf4SYHntosCw9xf2PEec1QSjnIZQRMPegtlF/QodgxsgnsAUdeXuia3UhO/AET /Va3oF35C2TBHSxPYE+OCkfjbGcjzl8EZ2Plpml9zyV4SlZmM8RTy3ykTSlwBHHbTKzP 7LrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=iBD6lZMrnBTLHBBN9+Gb5cpKL7uxMI++sU69V4zVy+g=; b=TikZLW6srELaODaSsEmVUS+GQ7u2rMUbi8v/S83BhDfWeEyST5AOBfh8VTxAmiK0nr YtRlgM1UAQ41LvKA7X5pZV4lzwSlB8KFqrV0LFelG7bm4i2UMTOgQcS8h0x2aL/A64Ap 1PdZR0LSb3UQER1m+Je6TTkjFID8D9jTUhulZt9TWhdapsiHVjTpuzoeQ4tHBbItG8qx 12Bk+wGEgktYDGWFajyc/oXBOY85jk0dh6gquRtKAsUjUCCnC7qaD4Wu8TBqWcrmtU1C MMMdZSUZkKHZ9MomWXFEbGJMNllqzb7vS9Das6Z65WfBYbS8RWFw2UYM86inRnPL5/IA R/5Q== X-Gm-Message-State: AJIora+6IiKY3XUUnE9et7V5IezaFNCSSg3Asz/gHFWU6zvufyl7w550 nbQGO27WpUVdHDjsB1Emf6S0Ow== X-Google-Smtp-Source: AGRyM1sr3Kjpsb3tAD/HFmc2IttIiLbrVd247d2nqDySkiBPggmJRbtunHeTvK6fNv2Hz4I6q88e0A== X-Received: by 2002:a05:600c:2f90:b0:39e:ee0d:6419 with SMTP id t16-20020a05600c2f9000b0039eee0d6419mr4526237wmn.59.1656084192817; Fri, 24 Jun 2022 08:23:12 -0700 (PDT) Received: from [192.168.0.237] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id r15-20020a05600c35cf00b003a0375c4f73sm2214189wmq.44.2022.06.24.08.23.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jun 2022 08:23:12 -0700 (PDT) Message-ID: Date: Fri, 24 Jun 2022 17:23:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v1 2/3] dt-bindings: pci: QCOM sc7280 add missing clocks. Content-Language: en-US To: Krishna chaitanya chundru , helgaas@kernel.org Cc: linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_vbadigan@quicinc.com, quic_hemantk@quicinc.com, quic_nitegupt@quicinc.com, quic_skananth@quicinc.com, quic_ramkri@quicinc.com, manivannan.sadhasivam@linaro.org, swboyd@chromium.org, dmitry.baryshkov@linaro.org, Andy Gross , Bjorn Andersson , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Stanimir Varbanov , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" References: <1656062391-14567-1-git-send-email-quic_krichai@quicinc.com> <1656062391-14567-3-git-send-email-quic_krichai@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <1656062391-14567-3-git-send-email-quic_krichai@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 24/06/2022 11:19, Krishna chaitanya chundru wrote: > Add missing clocks. > > Signed-off-by: Krishna chaitanya chundru > --- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index 0b69b12..313b981 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -438,6 +438,8 @@ allOf: > - const: slave_q2a # Slave Q2A clock > - const: tbu # PCIe TBU clock > - const: ddrss_sf_tbu # PCIe SF TBU clock > + - const: aggre0 # Aggre NoC PCIE CENTER SF AXI clock > + - const: aggre1 # Aggre NoC PCIe1 AXI clock Hi, This won't work. You need to update other entry. If you test it with `make dtbs_check` you will see the errors. Best regards, Krzysztof