From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39BD1C3A5A7 for ; Wed, 4 Sep 2019 15:32:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1905A22CF7 for ; Wed, 4 Sep 2019 15:32:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730011AbfIDPcQ (ORCPT ); Wed, 4 Sep 2019 11:32:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56100 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729773AbfIDPcQ (ORCPT ); Wed, 4 Sep 2019 11:32:16 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D5B2830A76A2; Wed, 4 Sep 2019 15:32:15 +0000 (UTC) Received: from [10.3.116.78] (ovpn-116-78.phx2.redhat.com [10.3.116.78]) by smtp.corp.redhat.com (Postfix) with ESMTP id DBABD60606; Wed, 4 Sep 2019 15:32:14 +0000 (UTC) Subject: Re: [Linux-kernel-mentees] [PATCH v2 2/3] PCI: sysfs: Change permissions from symbolic to octal To: Kelsey Skunberg Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Bodong Wang , Greg Kroah-Hartman References: <20190809195721.34237-1-skunberg.kelsey@gmail.com> <20190813204513.4790-1-skunberg.kelsey@gmail.com> <20190813204513.4790-3-skunberg.kelsey@gmail.com> <20190814053846.GA253360@google.com> <20190904062229.GA66871@JATN> From: Don Dutile Message-ID: Date: Wed, 4 Sep 2019 11:32:14 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190904062229.GA66871@JATN> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Wed, 04 Sep 2019 15:32:16 +0000 (UTC) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 09/04/2019 02:22 AM, Kelsey Skunberg wrote: > On Thu, Aug 15, 2019 at 10:37:13AM -0400, Don Dutile wrote: >> On 08/14/2019 01:38 AM, Bjorn Helgaas wrote: >>> [+cc Bodong, Don, Greg for permission question] >>> >>> On Tue, Aug 13, 2019 at 02:45:12PM -0600, Kelsey Skunberg wrote: >>>> Symbolic permissions such as "(S_IWUSR | S_IWGRP)" are not >>>> preferred and octal permissions should be used instead. Change all >>>> symbolic permissions to octal permissions. >>>> >>>> Example of old: >>>> >>>> "(S_IWUSR | S_IWGRP)" >>>> >>>> Example of new: >>>> >>>> "0220" >>> >>> >>>> static DEVICE_ATTR_RO(sriov_totalvfs); >>>> -static DEVICE_ATTR(sriov_numvfs, (S_IRUGO | S_IWUSR | S_IWGRP), >>>> - sriov_numvfs_show, sriov_numvfs_store); >>>> +static DEVICE_ATTR(sriov_numvfs, 0664, sriov_numvfs_show, sriov_numvfs_store); >>>> static DEVICE_ATTR_RO(sriov_offset); >>>> static DEVICE_ATTR_RO(sriov_stride); >>>> static DEVICE_ATTR_RO(sriov_vf_device); >>>> -static DEVICE_ATTR(sriov_drivers_autoprobe, (S_IRUGO | S_IWUSR | S_IWGRP), >>>> - sriov_drivers_autoprobe_show, sriov_drivers_autoprobe_store); >>>> +static DEVICE_ATTR(sriov_drivers_autoprobe, 0664, sriov_drivers_autoprobe_show, >>>> + sriov_drivers_autoprobe_store); >>> >>> Greg noticed that sriov_numvfs and sriov_drivers_autoprobe have >>> "unusual" permissions. These were added by: >>> >>> 0e7df22401a3 ("PCI: Add sysfs sriov_drivers_autoprobe to control VF driver binding") >>> 1789382a72a5 ("PCI: SRIOV control and status via sysfs") >>> >>> Kelsey's patch correctly preserves the existing permissions, but we >>> should double-check that they are the permissions they want, and >>> possibly add a comment about why they're different from the rest. >>> >>> Bjorn >>> > > Hi Don, > >> The rest being? ... 0644 vs 0664 ? >> The file is read & written, thus the (first) 6; I'll have to dig through very old (7 yr) notes to see if the second 6 is needed for libvirt (so it doesn't have to be root to enable). >> >> -dd >> > > Were you able to see if the unusual permissions (0664) are needed for > libvirt? I appreciate your help! > > -Kelsey > Asking libvirt team in RH; will get back as soon as I hear back. LPC time sink may delay the response. -dd