From: "Limonciello, Mario" <mario.limonciello@amd.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Alex Deucher <alexander.deucher@amd.com>,
bhelgaas@google.com, linux-pci@vger.kernel.org,
Marcin Bachry <hegel666@gmail.com>,
prike.liang@amd.com, shyam-sundar.s-k@amd.com
Subject: Re: [PATCH] PCI: quirks: Quirk PCI d3hot delay for AMD xhci
Date: Thu, 29 Jul 2021 16:09:50 -0500 [thread overview]
Message-ID: <ad2a6e91-47f2-fc1c-13ef-0cf23805bd75@amd.com> (raw)
In-Reply-To: <20210729210620.GA990816@bjorn-Precision-5520>
On 7/29/2021 16:06, Bjorn Helgaas wrote:
> On Thu, Jul 29, 2021 at 03:42:58PM -0500, Limonciello, Mario wrote:
>> On 7/29/2021 15:39, Bjorn Helgaas wrote:
>>> On Wed, Jul 21, 2021 at 10:58:58PM -0400, Alex Deucher wrote:
>>>> From: Marcin Bachry <hegel666@gmail.com>
>>>>
>>>> Renoir needs a similar delay.
>>>>
>>>> [Alex: I talked to the AMD USB hardware team and the
>>>> AMD windows team and they are not aware of any HW
>>>> errata or specific issues. The HW works fine in
>>>> windows. I was told windows uses a rather generous
>>>> default delay of 100ms for PCI state transitions.]
>>>>
>>>> Signed-off-by: Marcin Bachry <hegel666@gmail.com>
>>>> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>>>
>>> Added stable tag and applied to pci/pm for v5.15, thanks!
>>
>> Thanks Bjorn!
>>
>> Given how small/harmless this is and 5.14 isn't cut yet, any chance this
>> could still make one of the -rcX rather than wait for 5.14.1 instead?
>
> Done.
Thanks!
>
> What's the rest of the story here? Aare we working around a defect in
> these XHCI controllers? A defect in Linux? Obviously nobody wants to
> have to add a quirk for every new Device ID. It's not like this
> should be hard to figure out for your hardware guys in the lab, and if
> it turns out to be a Linux problem, we should fix it so everybody
> benefits.
>
Maybe you missed the embedded message from Alex above. We had a
discussion with our internal team that works with Windows on this, and
they told us the default delay is significantly more generous on Windows.
>>>> Cc: mario.limonciello@amd.com
>>>> Cc: prike.liang@amd.com
>>>> Cc: shyam-sundar.s-k@amd.com
>>>> ---
>>>>
>>>> Bjorn,
>>>>
>>>> With the above comment in mind, would you consider this patch
>>>> or would you prefer to increase the default timeout on Linux?
>>>> 100ms seems a bit long and most devices seems to work within
>>>> that limit. Additionally, this patch doesn't seem to be
>>>> required on all AMD platforms with the affected USB controller,
>>>> so I suspect the current timeout on Linux is probably about
>>>> right. Increasing it seems to fix some of the marginal cases.
>>>>
>>>> Alex
>>>>
>>>> drivers/pci/quirks.c | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
>>>> index 22b2bb1109c9..dea10d62d5b9 100644
>>>> --- a/drivers/pci/quirks.c
>>>> +++ b/drivers/pci/quirks.c
>>>> @@ -1899,6 +1899,7 @@ static void quirk_ryzen_xhci_d3hot(struct pci_dev *dev)
>>>> }
>>>> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, 0x15e0, quirk_ryzen_xhci_d3hot);
>>>> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, 0x15e1, quirk_ryzen_xhci_d3hot);
>>>> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, 0x1639, quirk_ryzen_xhci_d3hot);
>>>> #ifdef CONFIG_X86_IO_APIC
>>>> static int dmi_disable_ioapicreroute(const struct dmi_system_id *d)
>>>> --
>>>> 2.31.1
>>>>
>>
next prev parent reply other threads:[~2021-07-29 21:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 2:58 [PATCH] PCI: quirks: Quirk PCI d3hot delay for AMD xhci Alex Deucher
2021-07-29 20:39 ` Bjorn Helgaas
2021-07-29 20:42 ` Limonciello, Mario
2021-07-29 21:06 ` Bjorn Helgaas
2021-07-29 21:09 ` Limonciello, Mario [this message]
2021-07-29 21:30 ` Bjorn Helgaas
2021-07-29 21:34 ` Bjorn Helgaas
2021-07-30 14:17 ` Deucher, Alexander
-- strict thread matches above, loose matches on Subject: below --
2021-03-16 19:28 Alex Deucher
2021-03-18 18:36 ` Bjorn Helgaas
2021-03-19 18:11 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad2a6e91-47f2-fc1c-13ef-0cf23805bd75@amd.com \
--to=mario.limonciello@amd.com \
--cc=alexander.deucher@amd.com \
--cc=bhelgaas@google.com \
--cc=hegel666@gmail.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=prike.liang@amd.com \
--cc=shyam-sundar.s-k@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).