From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Message-ID: Subject: Re: PCIe enable device races (Was: [PATCH v3] PCI: Data corruption happening due to race condition) From: Benjamin Herrenschmidt To: Jens Axboe , Konstantin Khlebnikov , Bjorn Helgaas Cc: Hari Vyas , bhelgaas@google.com, linux-pci@vger.kernel.org, ray.jui@broadcom.com Date: Fri, 17 Aug 2018 09:09:28 +1000 In-Reply-To: <208f0e92-cf0c-3df1-5b16-2a8ec02b8d6d@kernel.dk> References: <1530608741-30664-1-git-send-email-hari.vyas@broadcom.com> <20180731163727.GK45322@bhelgaas-glaptop.roam.corp.google.com> <20180815185027.GE28888@bhelgaas-glaptop.roam.corp.google.com> <6f76eb5f54fdc780dac744773d836214d7844346.camel@kernel.crashing.org> <62ac393c-931a-f328-acf6-c9afc8a026ea@kernel.dk> <208f0e92-cf0c-3df1-5b16-2a8ec02b8d6d@kernel.dk> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-ID: On Thu, 2018-08-16 at 15:56 -0600, Jens Axboe wrote: > On 8/16/18 3:37 PM, Benjamin Herrenschmidt wrote: > > On Thu, 2018-08-16 at 13:43 -0600, Jens Axboe wrote: > > > > > > > Ok. Well, my patch fixes it for my repro-case at least and seems to not > > > > break anyhting on my thinkpad so ... > > > > > > > > Bjorn, are you ok with the approach ? If yes, I'll start breaking up > > > > that patch into a few smaller bits in case something goes wrong and we > > > > want to bisect (such as the changes I did to tracking is_busmaster > > > > etc...) > > > > > > I can try it too, but I was never CC'ed on the actual patch. > > > > https://lore.kernel.org/lkml/08bc40a6af3e614e97a78fbaab688bfcd14520ac.camel@kernel.crashing.org/ > > > > (I'll also fwd privately) > > Boots and works fine for me, but I'm also now on a gen6 x1, my initial > report was on a gen4. I still have the gen4, I can power it up and see > if it works there as well. Mine is a gen4 and it works fine :) Cheers, Ben.