From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support To: Christoph Hellwig , Joao Pinto , Kishon Vijay Abraham I References: <1487325042-28227-1-git-send-email-kishon@ti.com> <1487325042-28227-9-git-send-email-kishon@ti.com> <45e5288e-d11f-c855-af9b-692a42d878c6@synopsys.com> <58BE42B2.20305@ti.com> <02461be2-268d-485a-2bc4-3b148726d37d@synopsys.com> <58BFEC7D.3090608@ti.com> <35d539ba-956f-330e-c28d-b67c3d414578@synopsys.com> <58C00798.1030302@ti.com> <650c53fc-482c-feab-faa3-c30689d3d128@synopsys.com> <20170308191419.GA12085@infradead.org> From: Joao Pinto Message-ID: Date: Thu, 9 Mar 2017 11:55:01 +0000 MIME-Version: 1.0 In-Reply-To: <20170308191419.GA12085@infradead.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-doc@vger.kernel.org, Jingoo Han , nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="windows-1252" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: Hi Christoph, =C0s 7:14 PM de 3/8/2017, Christoph Hellwig escreveu: > On Wed, Mar 08, 2017 at 03:32:03PM +0000, Joao Pinto wrote: >> #define PCIE_GET_ATU_INB_UNR_REG_ADDR(region, register) \ >> ((0x3 << 20) | (region << 9) | \ >> (0x1 << 8) > = > Can you turn this and any similar macro into inline functions? > = Use an inline functions instead of macro is fine by me. In the initial patc= h I implemented as a macro since it only does simple bit shifts and nothing els= e and seemed simpler as a macro. Thanks, Joao _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel