From: Julia Lawall <julia.lawall@lip6.fr>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
Jiang Liu <jiang.liu@linux.intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Randy Dunlap <rdunlap@infradead.org>,
Yinghai Lu <yinghai@kernel.org>, Borislav Petkov <bp@alien8.de>,
Jason Cooper <jason@lakedaemon.net>,
Kevin Cernekee <cernekee@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Marc Zyngier <marc.zyngier@arm.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Tony Luck <tony.luck@intel.com>,
x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [RFC v1 14/25] genirq: Kill the first parameter 'irq' of irq_flow_handler_t
Date: Sat, 13 Jun 2015 23:42:45 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1506132337110.2020@localhost6.localdomain6> (raw)
In-Reply-To: <alpine.DEB.2.11.1506132230450.3786@nanos>
The semantic patch below considers the problem from another point of view,
to find functions that may have a handler as an argument. The results
that are different than those considered already are as follows:
arch/x86/platform/uv/uv_irq.c:106 irq_domain_set_info
has a possible handler in argument 6
arch/sparc/kernel/leon_pci_grpci2.c:815 leon_update_virq_handling
has a possible handler in argument 2
arch/sparc/kernel/leon_kernel.c:79 leon_build_device_irq
has a possible handler in argument 2
arch/arm/mach-omap2/prm_common.c:331 irq_alloc_generic_chip
has a possible handler in argument 5
arch/mips/cavium-octeon/octeon-irq.c:1231 octeon_irq_set_ciu_mapping
has a possible handler in argument 6
arch/blackfin/mach-common/ints-priority.c:805 bfin_set_irq_handler
has a possible handler in argument 2
arch/m68k/q40/q40ints.c:84 m68k_setup_irq_controller
has a possible handler in argument 2
drivers/gpio/gpio-pcf857x.c:362 gpiochip_irqchip_add
has a possible handler in argument 4
The semantic patch looks for a function that has as argument a function
that has arguments of type (unsigned int irq, struct irq_desc *desc) and a
void return type. It also looks for functions that have as argument a
bunch of known irq handlers.
julia
@initialize:ocaml@
@@
let tbl = Hashtbl.create 101
let ln = Str.regexp "linux-next/" (* update as appropriate *)
let _ =
List.iter (function x -> Hashtbl.add tbl x ())
[("__irq_set_handler",2);("irq_set_handler",2);
("irq_set_chained_handler",2);("irq_alloc_generic_chip",4);
("irq_alloc_domain_generic_chips",5);("irq_set_chip_and_handler_name",3);
("irq_set_chip_and_handler",3);("__irq_set_handler_locked",2);
("__irq_set_chip_handler_name_locked",3);("__irq_set_preflow_handler",2);
("gpiochip_set_chained_irqchip",4)]
let update g f n p =
let n = n + 1 in
let entry = (g,n) in
try let _ = Hashtbl.find tbl entry in ()
with Not_found ->
begin
Hashtbl.add tbl entry ();
let p = List.hd p in
Printf.printf "%s:%d %s\n\thas a possible handler in argument %d\n"
(List.nth (Str.split ln p.file) 1) p.line g
n
end
@possible_handler@
identifier f,irq,desc;
@@
void f(unsigned int irq, struct irq_desc *desc) { ... }
@call@
identifier g,possible_handler.f;
expression list[n] es;
position p;
@@
g(es,f@p,...)
@script:ocaml@
p << call.p;
f << possible_handler.f;
g << call.g;
n << call.n;
@@
update g f n p
@call2@
identifier g,f;
expression list[n] es;
position p;
symbol handle_level_irq,handle_simple_irq,handle_edge_irq,
handle_fasteoi_irq,handle_percpu_irq;
@@
g(es,\(handle_level_irq@f@p\|handle_simple_irq@f@p\|handle_edge_irq@f@p\|
handle_fasteoi_irq@f@p\|handle_percpu_irq@f@p\),...)
@script:ocaml@
p << call2.p;
f << call2.f;
g << call2.g;
n << call2.n;
@@
update g f n p
next prev parent reply other threads:[~2015-06-13 21:42 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 9:59 [RFC v1 00/25] Optimize irq flow handler Jiang Liu
2015-05-20 9:59 ` [RFC v1 01/25] ARM, irq: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc Jiang Liu
2015-05-20 19:35 ` Russell King - ARM Linux
2015-05-20 9:59 ` [RFC v1 02/25] avr32, " Jiang Liu
2015-05-20 10:15 ` Hans-Christian Egtvedt
2015-05-20 9:59 ` [RFC v1 03/25] MIPS, " Jiang Liu
2015-05-20 9:59 ` [RFC v1 04/25] powerpc, " Jiang Liu
2015-05-20 9:59 ` [RFC v1 05/25] gpio: " Jiang Liu
2015-06-01 12:45 ` Linus Walleij
2015-06-01 13:48 ` Jiang Liu
2015-05-20 9:59 ` [RFC v1 06/25] pinctrl: " Jiang Liu
2015-05-20 9:59 ` [RFC v1 07/25] irqchip: " Jiang Liu
2015-05-20 9:59 ` [RFC v1 08/25] mfd: " Jiang Liu
2015-05-20 10:44 ` Lee Jones
2015-05-20 9:59 ` [RFC v1 09/25] ipu: " Jiang Liu
2015-05-20 9:59 ` [RFC v1 10/25] sh: intc: " Jiang Liu
2015-05-20 15:12 ` Thomas Gleixner
2015-05-20 15:24 ` Jiang Liu
2015-05-20 9:59 ` [RFC v1 11/25] keystone, irq: Use irq_data_get_xxx() to avoid redundant lookup of irq_data Jiang Liu
2015-05-20 10:00 ` [RFC v1 12/25] spmi: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc Jiang Liu
2015-05-20 10:00 ` [RFC v1 13/25] genirq: Kill the parameter 'irq' of kstat_incr_irqs_this_cpu() Jiang Liu
2015-05-20 15:23 ` Thomas Gleixner
2015-05-20 10:00 ` [RFC v1 14/25] genirq: Kill the first parameter 'irq' of irq_flow_handler_t Jiang Liu
2015-05-20 15:25 ` Thomas Gleixner
2015-05-20 15:28 ` Jiang Liu
2015-05-20 18:35 ` Thomas Gleixner
2015-05-20 20:00 ` Julia Lawall
2015-05-20 20:12 ` Thomas Gleixner
2015-05-20 20:15 ` Julia Lawall
2015-05-20 20:22 ` Thomas Gleixner
2015-06-12 20:29 ` Julia Lawall
2015-06-12 20:35 ` Thomas Gleixner
2015-06-12 22:16 ` Julia Lawall
2015-06-13 8:27 ` Julia Lawall
2015-06-13 9:00 ` Julia Lawall
2015-06-13 9:32 ` Thomas Gleixner
2015-06-13 14:04 ` Julia Lawall
2015-06-13 14:53 ` Julia Lawall
2015-06-13 16:49 ` Jiang Liu
2015-06-13 20:15 ` Julia Lawall
2015-06-13 20:32 ` Thomas Gleixner
2015-06-13 20:42 ` Julia Lawall
2015-06-24 21:10 ` Thomas Gleixner
2015-06-24 21:44 ` Julia Lawall
2015-06-13 21:42 ` Julia Lawall [this message]
2015-05-20 18:36 ` Thomas Gleixner
2015-05-20 10:00 ` [RFC v1 15/25] " Jiang Liu
2015-05-20 15:28 ` Thomas Gleixner
2015-05-20 15:32 ` Jiang Liu
2015-05-20 15:48 ` Thomas Gleixner
2015-05-20 15:38 ` Hans Ulli Kroll
2015-05-20 18:54 ` Robert Jarzmik
2015-05-20 10:00 ` [RFC v1 16/25] " Jiang Liu
2015-05-20 10:00 ` [RFC v1 17/25] " Jiang Liu
2015-05-20 10:00 ` [RFC v1 18/25] " Jiang Liu
2015-05-20 10:00 ` [RFC v1 19/25] " Jiang Liu
2015-05-20 10:00 ` [RFC v1 20/25] " Jiang Liu
2015-05-20 10:16 ` Hans-Christian Egtvedt
2015-05-20 10:00 ` [RFC v1 21/25] " Jiang Liu
2015-05-20 10:00 ` [RFC v1 22/25] " Jiang Liu
2015-05-20 10:00 ` [RFC v1 23/25] " Jiang Liu
2015-05-20 10:00 ` [RFC v1 24/25] " Jiang Liu
2015-05-20 10:43 ` Lee Jones
2015-05-20 10:00 ` [RFC v1 25/25] " Jiang Liu
2015-05-20 15:40 ` Thomas Gleixner
2015-05-20 15:49 ` Jiang Liu
2015-05-20 18:43 ` Thomas Gleixner
2015-05-20 10:16 ` [RFC v1 00/25] Optimize irq flow handler Ingo Molnar
2015-05-20 10:23 ` Jiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1506132337110.2020@localhost6.localdomain6 \
--to=julia.lawall@lip6.fr \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=cernekee@gmail.com \
--cc=hpa@zytor.com \
--cc=jason@lakedaemon.net \
--cc=jiang.liu@linux.intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mingo@redhat.com \
--cc=rdunlap@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).