From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from www.linutronix.de ([62.245.132.108]:33599 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753563AbbETP2n (ORCPT ); Wed, 20 May 2015 11:28:43 -0400 Date: Wed, 20 May 2015 17:28:06 +0200 (CEST) From: Thomas Gleixner To: Jiang Liu cc: Bjorn Helgaas , Benjamin Herrenschmidt , Ingo Molnar , "H. Peter Anvin" , "Rafael J. Wysocki" , Randy Dunlap , Yinghai Lu , Borislav Petkov , Russell King , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Hans Ulli Kroll , Shawn Guo , Sascha Hauer , Roland Stigge , Tony Lindgren , Rajendra Nayak , Paul Walmsley , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Kukjin Kim , Krzysztof Kozlowski , Arnd Bergmann , Konrad Rzeszutek Wilk , Tony Luck , x86@kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [RFC v1 15/25] genirq: Kill the first parameter 'irq' of irq_flow_handler_t In-Reply-To: <1432116013-25902-16-git-send-email-jiang.liu@linux.intel.com> Message-ID: References: <1432116013-25902-1-git-send-email-jiang.liu@linux.intel.com> <1432116013-25902-16-git-send-email-jiang.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-pci-owner@vger.kernel.org List-ID: On Wed, 20 May 2015, Jiang Liu wrote: > -static void locomo_handler(unsigned int irq, struct irq_desc *desc) > +static void locomo_handler(struct irq_desc *desc) > { > struct locomo *lchip = irq_desc_get_chip_data(desc); > + unsigned int irq; > int req, i; That leaves irq unitialized .... Thanks, tglx