From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Bjorn Helgaas <helgaas@kernel.org>, Palmer Dabbelt <palmer@dabbelt.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Avoid handing out address 0 to devices
Date: Thu, 14 Apr 2022 21:22:42 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2204142111010.9383@angie.orcam.me.uk> (raw)
In-Reply-To: <20220414170743.GA753251@bhelgaas>
On Thu, 14 Apr 2022, Bjorn Helgaas wrote:
> > > > Address 0 is treated specially however in many places, for example in
> > > > `pci_iomap_range' and `pci_iomap_wc_range' we require that the start
> > > > address is non-zero, and even if we let such an address through, then
> > > > individual device drivers could reject a request to handle a device at
> > > > such an address, such as in `uart_configure_port'. Consequently given
> > > > devices configured as shown above only one is actually usable:
> > >
> > > pci_iomap_range() tests the resource start, i.e., the CPU address. I
> > > guess the implication is that on RISC-V, the CPU-side port address is
> > > the same as the PCI bus port address?
> >
> > Umm, for all systems I came across except x86, which have native port I/O
> > access machine instructions, a port I/O resource records PCI bus addresses
> > of the device rather than its CPU addresses, which encode the location of
> > an MMIO window the PCI port I/O space is accessed through.
>
> My point is only that it is not necessary for the PCI bus address and
> the struct resource address, i.e., the argument to inb(), to be the
> same.
Sure, but I have yet to see a system where it is the case.
Also in principle peer PCI buses could have their own port I/O address
spaces each mapped via distinct MMIO windows in the CPU address space, but
I haven't heard of such a system. That of course doesn't mean there's no
such system in existence.
> I tried to find the RISC-V definition of inb(), but it's obfuscated
> too much to be easily discoverable.
AFAICT the RISC-V port uses definitions from include/asm-generic/io.h.
Palmer, did I get this right?
Maciej
next prev parent reply other threads:[~2022-04-14 20:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-26 10:47 [PATCH] PCI: Avoid handing out address 0 to devices Maciej W. Rozycki
2022-03-31 7:11 ` [PING][PATCH] " Maciej W. Rozycki
2022-04-13 22:53 ` [PING^2][PATCH] " Maciej W. Rozycki
2022-04-14 0:06 ` [PATCH] " Bjorn Helgaas
2022-04-14 1:10 ` Maciej W. Rozycki
2022-04-14 17:07 ` Bjorn Helgaas
2022-04-14 20:22 ` Maciej W. Rozycki [this message]
2022-04-14 22:12 ` Palmer Dabbelt
2022-04-14 23:23 ` Bjorn Helgaas
2022-04-15 12:27 ` Maciej W. Rozycki
2022-04-15 18:39 ` Bjorn Helgaas
2022-04-16 14:02 ` Maciej W. Rozycki
2022-04-19 3:37 ` Bjorn Helgaas
2022-04-27 22:18 ` Maciej W. Rozycki
2022-04-28 18:55 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2204142111010.9383@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).