From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-pci-owner@vger.kernel.org>
Received: from mga02.intel.com ([134.134.136.20]:54771 "EHLO mga02.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751267AbaDVB5u (ORCPT <rfc822;linux-pci@vger.kernel.org>);
	Mon, 21 Apr 2014 21:57:50 -0400
Date: Mon, 21 Apr 2014 19:57:48 -0600 (MDT)
From: Keith Busch <keith.busch@intel.com>
To: Learner Study <learner.study@gmail.com>
cc: Keith Busch <keith.busch@intel.com>, linux-pci@vger.kernel.org,
	linux-nvme <linux-nvme@lists.infradead.org>, bhelgaas@google.com
Subject: Re: [PATCH 2/2] NVMe: Implement PCI-e reset notification callback
In-Reply-To: <CAP8+hKWcybw5u_m5M4c1p4eUAaTq4x+kO+tnegwD2ciDMEFNCw@mail.gmail.com>
Message-ID: <alpine.LRH.2.03.1404211935510.5490@AMR>
References: <1397000541-1085-1-git-send-email-keith.busch@intel.com> <1397000541-1085-2-git-send-email-keith.busch@intel.com> <CAP8+hKWcybw5u_m5M4c1p4eUAaTq4x+kO+tnegwD2ciDMEFNCw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Sender: linux-pci-owner@vger.kernel.org
List-ID: <linux-pci.vger.kernel.org>

On Mon, 21 Apr 2014, Learner Study wrote:
> Hi Keith,
>
> I think NVMe Reset should apply to PF mode driver only, and not to VF
> mode driver.
> Is that understanding correct? Does the NVMe driver know which mode
> its running in?

Oh, this driver doesn't enable SR-IOV and has no PF/VF awareness. Shame
on us, I'll add it to my list unless someone beats me to it.

Still, I think we'd like to be able to reset a VF if only because it
gets the queues back to a pristine state. A VF reset should not affect
any of the other functions.