* [PATCH v3] PCI: mediatek-gen3: Disable DVFSRC voltage request
@ 2021-10-15 6:36 Jianjun Wang
2021-11-09 6:10 ` Jianjun Wang
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jianjun Wang @ 2021-10-15 6:36 UTC (permalink / raw)
To: Lorenzo Pieralisi, Rob Herring, Krzysztof Wilczyński,
Bjorn Helgaas, Ryder Lee, Matthias Brugger
Cc: linux-pci, linux-mediatek, linux-kernel, linux-arm-kernel,
Jianjun Wang, qizhong.cheng, Ryan-JH.Yu, Tzung-Bi Shih
When the DVFSRC (dynamic voltage and frequency scaling resource collector)
feature is not implemented, the PCIe hardware will assert a voltage request
signal when exit from the L1 PM Substates to request a specific Vcore
voltage, but cannot receive the voltage ready signal, which will cause
the link to fail to exit the L1 PM Substates.
Disable DVFSRC voltage request by default, we need to find a common way to
enable it in the future.
Fixes: d3bf75b579b9 ("PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192")
Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
Tested-by: Qizhong Cheng <qizhong.cheng@mediatek.com>
---
drivers/pci/controller/pcie-mediatek-gen3.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
index f3aeb8d4eaca..79fb12fca6a9 100644
--- a/drivers/pci/controller/pcie-mediatek-gen3.c
+++ b/drivers/pci/controller/pcie-mediatek-gen3.c
@@ -79,6 +79,9 @@
#define PCIE_ICMD_PM_REG 0x198
#define PCIE_TURN_OFF_LINK BIT(4)
+#define PCIE_MISC_CTRL_REG 0x348
+#define PCIE_DISABLE_DVFSRC_VLT_REQ BIT(1)
+
#define PCIE_TRANS_TABLE_BASE_REG 0x800
#define PCIE_ATR_SRC_ADDR_MSB_OFFSET 0x4
#define PCIE_ATR_TRSL_ADDR_LSB_OFFSET 0x8
@@ -297,6 +300,11 @@ static int mtk_pcie_startup_port(struct mtk_pcie_port *port)
val &= ~PCIE_INTX_ENABLE;
writel_relaxed(val, port->base + PCIE_INT_ENABLE_REG);
+ /* Disable DVFSRC voltage request */
+ val = readl_relaxed(port->base + PCIE_MISC_CTRL_REG);
+ val |= PCIE_DISABLE_DVFSRC_VLT_REQ;
+ writel_relaxed(val, port->base + PCIE_MISC_CTRL_REG);
+
/* Assert all reset signals */
val = readl_relaxed(port->base + PCIE_RST_CTRL_REG);
val |= PCIE_MAC_RSTB | PCIE_PHY_RSTB | PCIE_BRG_RSTB | PCIE_PE_RSTB;
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3] PCI: mediatek-gen3: Disable DVFSRC voltage request
2021-10-15 6:36 [PATCH v3] PCI: mediatek-gen3: Disable DVFSRC voltage request Jianjun Wang
@ 2021-11-09 6:10 ` Jianjun Wang
2021-11-29 2:51 ` Jianjun Wang
2021-11-17 17:41 ` Matthias Brugger
2021-11-29 12:10 ` Lorenzo Pieralisi
2 siblings, 1 reply; 5+ messages in thread
From: Jianjun Wang @ 2021-11-09 6:10 UTC (permalink / raw)
To: Lorenzo Pieralisi, Rob Herring, Krzysztof Wilczyński,
Bjorn Helgaas, Ryder Lee, Matthias Brugger
Cc: linux-pci, linux-mediatek, linux-kernel, linux-arm-kernel,
qizhong.cheng, Ryan-JH.Yu, Tzung-Bi Shih
Hi Maintainers,
Just gentle ping for this patch, if there is anything I need to modify,
please kindly let me know.
Thanks.
On Fri, 2021-10-15 at 14:36 +0800, Jianjun Wang wrote:
> When the DVFSRC (dynamic voltage and frequency scaling resource
> collector)
> feature is not implemented, the PCIe hardware will assert a voltage
> request
> signal when exit from the L1 PM Substates to request a specific Vcore
> voltage, but cannot receive the voltage ready signal, which will
> cause
> the link to fail to exit the L1 PM Substates.
>
> Disable DVFSRC voltage request by default, we need to find a common
> way to
> enable it in the future.
>
> Fixes: d3bf75b579b9 ("PCI: mediatek-gen3: Add MediaTek Gen3 driver
> for MT8192")
> Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
> Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
> Tested-by: Qizhong Cheng <qizhong.cheng@mediatek.com>
> ---
> drivers/pci/controller/pcie-mediatek-gen3.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c
> b/drivers/pci/controller/pcie-mediatek-gen3.c
> index f3aeb8d4eaca..79fb12fca6a9 100644
> --- a/drivers/pci/controller/pcie-mediatek-gen3.c
> +++ b/drivers/pci/controller/pcie-mediatek-gen3.c
> @@ -79,6 +79,9 @@
> #define PCIE_ICMD_PM_REG 0x198
> #define PCIE_TURN_OFF_LINK BIT(4)
>
> +#define PCIE_MISC_CTRL_REG 0x348
> +#define PCIE_DISABLE_DVFSRC_VLT_REQ BIT(1)
> +
> #define PCIE_TRANS_TABLE_BASE_REG 0x800
> #define PCIE_ATR_SRC_ADDR_MSB_OFFSET 0x4
> #define PCIE_ATR_TRSL_ADDR_LSB_OFFSET 0x8
> @@ -297,6 +300,11 @@ static int mtk_pcie_startup_port(struct
> mtk_pcie_port *port)
> val &= ~PCIE_INTX_ENABLE;
> writel_relaxed(val, port->base + PCIE_INT_ENABLE_REG);
>
> + /* Disable DVFSRC voltage request */
> + val = readl_relaxed(port->base + PCIE_MISC_CTRL_REG);
> + val |= PCIE_DISABLE_DVFSRC_VLT_REQ;
> + writel_relaxed(val, port->base + PCIE_MISC_CTRL_REG);
> +
> /* Assert all reset signals */
> val = readl_relaxed(port->base + PCIE_RST_CTRL_REG);
> val |= PCIE_MAC_RSTB | PCIE_PHY_RSTB | PCIE_BRG_RSTB |
> PCIE_PE_RSTB;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] PCI: mediatek-gen3: Disable DVFSRC voltage request
2021-10-15 6:36 [PATCH v3] PCI: mediatek-gen3: Disable DVFSRC voltage request Jianjun Wang
2021-11-09 6:10 ` Jianjun Wang
@ 2021-11-17 17:41 ` Matthias Brugger
2021-11-29 12:10 ` Lorenzo Pieralisi
2 siblings, 0 replies; 5+ messages in thread
From: Matthias Brugger @ 2021-11-17 17:41 UTC (permalink / raw)
To: Jianjun Wang, Lorenzo Pieralisi, Rob Herring,
Krzysztof Wilczyński, Bjorn Helgaas, Ryder Lee
Cc: linux-pci, linux-mediatek, linux-kernel, linux-arm-kernel,
qizhong.cheng, Ryan-JH.Yu, Tzung-Bi Shih
On 15/10/2021 08:36, Jianjun Wang wrote:
> When the DVFSRC (dynamic voltage and frequency scaling resource collector)
> feature is not implemented, the PCIe hardware will assert a voltage request
> signal when exit from the L1 PM Substates to request a specific Vcore
> voltage, but cannot receive the voltage ready signal, which will cause
> the link to fail to exit the L1 PM Substates.
>
> Disable DVFSRC voltage request by default, we need to find a common way to
> enable it in the future.
>
> Fixes: d3bf75b579b9 ("PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192")
> Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
> Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
> Tested-by: Qizhong Cheng <qizhong.cheng@mediatek.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/pci/controller/pcie-mediatek-gen3.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
> index f3aeb8d4eaca..79fb12fca6a9 100644
> --- a/drivers/pci/controller/pcie-mediatek-gen3.c
> +++ b/drivers/pci/controller/pcie-mediatek-gen3.c
> @@ -79,6 +79,9 @@
> #define PCIE_ICMD_PM_REG 0x198
> #define PCIE_TURN_OFF_LINK BIT(4)
>
> +#define PCIE_MISC_CTRL_REG 0x348
> +#define PCIE_DISABLE_DVFSRC_VLT_REQ BIT(1)
> +
> #define PCIE_TRANS_TABLE_BASE_REG 0x800
> #define PCIE_ATR_SRC_ADDR_MSB_OFFSET 0x4
> #define PCIE_ATR_TRSL_ADDR_LSB_OFFSET 0x8
> @@ -297,6 +300,11 @@ static int mtk_pcie_startup_port(struct mtk_pcie_port *port)
> val &= ~PCIE_INTX_ENABLE;
> writel_relaxed(val, port->base + PCIE_INT_ENABLE_REG);
>
> + /* Disable DVFSRC voltage request */
> + val = readl_relaxed(port->base + PCIE_MISC_CTRL_REG);
> + val |= PCIE_DISABLE_DVFSRC_VLT_REQ;
> + writel_relaxed(val, port->base + PCIE_MISC_CTRL_REG);
> +
> /* Assert all reset signals */
> val = readl_relaxed(port->base + PCIE_RST_CTRL_REG);
> val |= PCIE_MAC_RSTB | PCIE_PHY_RSTB | PCIE_BRG_RSTB | PCIE_PE_RSTB;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] PCI: mediatek-gen3: Disable DVFSRC voltage request
2021-11-09 6:10 ` Jianjun Wang
@ 2021-11-29 2:51 ` Jianjun Wang
0 siblings, 0 replies; 5+ messages in thread
From: Jianjun Wang @ 2021-11-29 2:51 UTC (permalink / raw)
To: Lorenzo Pieralisi, Rob Herring, Krzysztof Wilczyński,
Bjorn Helgaas, Ryder Lee, Matthias Brugger
Cc: linux-pci, linux-mediatek, linux-kernel, linux-arm-kernel,
qizhong.cheng, Ryan-JH.Yu, Tzung-Bi Shih
Hi Maintainers,
Just gentle ping for this patch, is there anything I need to do to get
this patch merged?
Thanks.
On Tue, 2021-11-09 at 14:10 +0800, Jianjun Wang wrote:
>
> On Fri, 2021-10-15 at 14:36 +0800, Jianjun Wang wrote:
> > When the DVFSRC (dynamic voltage and frequency scaling resource
> > collector)
> > feature is not implemented, the PCIe hardware will assert a voltage
> > request
> > signal when exit from the L1 PM Substates to request a specific
> > Vcore
> > voltage, but cannot receive the voltage ready signal, which will
> > cause
> > the link to fail to exit the L1 PM Substates.
> >
> > Disable DVFSRC voltage request by default, we need to find a common
> > way to
> > enable it in the future.
> >
> > Fixes: d3bf75b579b9 ("PCI: mediatek-gen3: Add MediaTek Gen3 driver
> > for MT8192")
> > Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
> > Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
> > Tested-by: Qizhong Cheng <qizhong.cheng@mediatek.com>
> > ---
> > drivers/pci/controller/pcie-mediatek-gen3.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c
> > b/drivers/pci/controller/pcie-mediatek-gen3.c
> > index f3aeb8d4eaca..79fb12fca6a9 100644
> > --- a/drivers/pci/controller/pcie-mediatek-gen3.c
> > +++ b/drivers/pci/controller/pcie-mediatek-gen3.c
> > @@ -79,6 +79,9 @@
> > #define PCIE_ICMD_PM_REG 0x198
> > #define PCIE_TURN_OFF_LINK BIT(4)
> >
> > +#define PCIE_MISC_CTRL_REG 0x348
> > +#define PCIE_DISABLE_DVFSRC_VLT_REQ BIT(1)
> > +
> > #define PCIE_TRANS_TABLE_BASE_REG 0x800
> > #define PCIE_ATR_SRC_ADDR_MSB_OFFSET 0x4
> > #define PCIE_ATR_TRSL_ADDR_LSB_OFFSET 0x8
> > @@ -297,6 +300,11 @@ static int mtk_pcie_startup_port(struct
> > mtk_pcie_port *port)
> > val &= ~PCIE_INTX_ENABLE;
> > writel_relaxed(val, port->base + PCIE_INT_ENABLE_REG);
> >
> > + /* Disable DVFSRC voltage request */
> > + val = readl_relaxed(port->base + PCIE_MISC_CTRL_REG);
> > + val |= PCIE_DISABLE_DVFSRC_VLT_REQ;
> > + writel_relaxed(val, port->base + PCIE_MISC_CTRL_REG);
> > +
> > /* Assert all reset signals */
> > val = readl_relaxed(port->base + PCIE_RST_CTRL_REG);
> > val |= PCIE_MAC_RSTB | PCIE_PHY_RSTB | PCIE_BRG_RSTB |
> > PCIE_PE_RSTB;
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] PCI: mediatek-gen3: Disable DVFSRC voltage request
2021-10-15 6:36 [PATCH v3] PCI: mediatek-gen3: Disable DVFSRC voltage request Jianjun Wang
2021-11-09 6:10 ` Jianjun Wang
2021-11-17 17:41 ` Matthias Brugger
@ 2021-11-29 12:10 ` Lorenzo Pieralisi
2 siblings, 0 replies; 5+ messages in thread
From: Lorenzo Pieralisi @ 2021-11-29 12:10 UTC (permalink / raw)
To: Jianjun Wang, Matthias Brugger, Krzysztof Wilczyński,
Ryder Lee, Bjorn Helgaas, Rob Herring
Cc: Lorenzo Pieralisi, linux-arm-kernel, linux-kernel,
linux-mediatek, Ryan-JH.Yu, qizhong.cheng, Tzung-Bi Shih,
linux-pci
On Fri, 15 Oct 2021 14:36:02 +0800, Jianjun Wang wrote:
> When the DVFSRC (dynamic voltage and frequency scaling resource collector)
> feature is not implemented, the PCIe hardware will assert a voltage request
> signal when exit from the L1 PM Substates to request a specific Vcore
> voltage, but cannot receive the voltage ready signal, which will cause
> the link to fail to exit the L1 PM Substates.
>
> Disable DVFSRC voltage request by default, we need to find a common way to
> enable it in the future.
>
> [...]
Applied to pci/mediatek-gen3, thanks!
[1/1] PCI: mediatek-gen3: Disable DVFSRC voltage request
https://git.kernel.org/lpieralisi/pci/c/ab344fd43f
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-11-29 12:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-15 6:36 [PATCH v3] PCI: mediatek-gen3: Disable DVFSRC voltage request Jianjun Wang
2021-11-09 6:10 ` Jianjun Wang
2021-11-29 2:51 ` Jianjun Wang
2021-11-17 17:41 ` Matthias Brugger
2021-11-29 12:10 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).