From: Liu Peibao <liupeibao@loongson.cn>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>
Cc: chenhuacai@loongson.cn, lvjianmin@loongson.cn,
zhuyinbo@loongson.cn, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: PCI: loongson: Add skip-scan property for child node
Date: Fri, 4 Nov 2022 14:42:12 +0800 [thread overview]
Message-ID: <b3479058-34f5-1084-d1a4-5c6e2ad16959@loongson.cn> (raw)
In-Reply-To: <01e8e789-68a8-626e-1a47-814d182807e7@linaro.org>
On 11/4/22 5:53 AM, Krzysztof Kozlowski wrote:
> On 03/11/2022 05:00, Liu Peibao wrote:
>> Add the newly added "skip-scan" property for child node.
>
> This we can see from the patch log. You need to say answer here to "Why".
>
I will take care of this when I submit new patches.
>>
>> Signed-off-by: Liu Peibao <liupeibao@loongson.cn>
>> ---
>> Documentation/devicetree/bindings/pci/loongson.yaml | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/loongson.yaml b/Documentation/devicetree/bindings/pci/loongson.yaml
>> index a8324a9bd002..5c2fe9bf2c78 100644
>> --- a/Documentation/devicetree/bindings/pci/loongson.yaml
>> +++ b/Documentation/devicetree/bindings/pci/loongson.yaml
>> @@ -32,6 +32,13 @@ properties:
>> minItems: 1
>> maxItems: 3
>>
>> + child-node:
>
> What is "child-node"?
>
>> + type: object
>> + properties:
>> + skip-scan:
>> + description: avoid scanning this device.
>> + type: boolean
>
> Why? Isn't status for that?
>
> You also need additionalProperties: false/true, depending on what this
> child-node is...
>
> ...and add the case illustrating it in the example.
>
>
I think I did add some vague description.
Since the opinion of Jiaxun in the [PATCH 1/2] is really more elegant
than what I did. I decide follow this opinion and as the `status = "disabled"`
property is existing, I will don't modify this yaml.
Thanks for your detailed review!
BR,
Peibao
next prev parent reply other threads:[~2022-11-04 6:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 9:00 [PATCH 1/2] PCI: loongson: add skip-scan property for child DT node Liu Peibao
2022-11-03 9:00 ` [PATCH 2/2] dt-bindings: PCI: loongson: Add skip-scan property for child node Liu Peibao
2022-11-03 21:53 ` Krzysztof Kozlowski
2022-11-04 6:42 ` Liu Peibao [this message]
2022-11-03 11:37 ` [PATCH 1/2] PCI: loongson: add skip-scan property for child DT node Jiaxun Yang
2022-11-04 6:36 ` Liu Peibao
2022-11-17 4:12 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3479058-34f5-1084-d1a4-5c6e2ad16959@loongson.cn \
--to=liupeibao@loongson.cn \
--cc=bhelgaas@google.com \
--cc=chenhuacai@loongson.cn \
--cc=devicetree@vger.kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=lvjianmin@loongson.cn \
--cc=robh+dt@kernel.org \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).