From: "Kuppuswamy, Sathyanarayanan" <sathyanarayanan.kuppuswamy@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
ashok.raj@intel.com
Subject: Re: [PATCH v1 1/1] PCI/EDR: Change ACPI event message log level
Date: Fri, 24 Apr 2020 16:15:13 -0700 [thread overview]
Message-ID: <b50c101e-e603-6602-3fbb-b7b118f61ef8@linux.intel.com> (raw)
In-Reply-To: <20200424231002.GA218107@google.com>
Hi Bjorn,
On 4/24/20 4:10 PM, Bjorn Helgaas wrote:
> On Wed, Apr 15, 2020 at 05:38:32PM -0700, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
>> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>>
>> Currently we have pci_info() message in the beginning of
>> edr_handle_event() function, which will be printing
>> notification details every-time firmware sends ACPI SYSTEM
>> level events. This will pollute the dmesg logs for systems
>> that has lot for ACPI system level notifications. So change
>> the log-level to pci_dbg, and add a new info log for EDR
>> events.
>>
>> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>> ---
>> drivers/pci/pcie/edr.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/pcie/edr.c b/drivers/pci/pcie/edr.c
>> index 594622a6cb16..e346c82559fa 100644
>> --- a/drivers/pci/pcie/edr.c
>> +++ b/drivers/pci/pcie/edr.c
>> @@ -148,11 +148,13 @@ static void edr_handle_event(acpi_handle handle, u32 event, void *data)
>> pci_ers_result_t estate = PCI_ERS_RESULT_DISCONNECT;
>> u16 status;
>>
>> - pci_info(pdev, "ACPI event %#x received\n", event);
>> + pci_dbg(pdev, "ACPI event %#x received\n", event);
>
> I agree this looks excessively verbose. Do we even need a pci_dbg()
> message here? Maybe a message like that would belong in ACPI?
> There is already an ACPI_DEBUG_PRINT() in
> acpi_ev_queue_notify_request() that would serve a similar purpose.
I tried to keep it here to simplify enabling debug logs related to
EDR. But as you have mentioned we could get similar message from
ACPI. If you think its excessive we can remove it. You want me to
send next version with this change ?
>
>> if (event != ACPI_NOTIFY_DISCONNECT_RECOVER)
>> return;
>>
>> + pci_info(pdev, "EDR event received\n");
>> +
>> /* Locate the port which issued EDR event */
>> edev = acpi_dpc_port_get(pdev);
>> if (!edev) {
>> --
>> 2.17.1
>>
next prev parent reply other threads:[~2020-04-24 23:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 0:38 [PATCH v1 1/1] PCI/EDR: Change ACPI event message log level sathyanarayanan.kuppuswamy
2020-04-24 23:10 ` Bjorn Helgaas
2020-04-24 23:15 ` Kuppuswamy, Sathyanarayanan [this message]
2020-04-24 23:36 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b50c101e-e603-6602-3fbb-b7b118f61ef8@linux.intel.com \
--to=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).