From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Zhiqiang Hou" <Zhiqiang.Hou@nxp.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
lorenzo.pieralisi@arm.com, robh@kernel.org, bhelgaas@google.com,
gustavo.pimentel@synopsys.com, jingoohan1@gmail.com,
정재훈 <jh80.chung@samsung.com>
Subject: Re: [PATCH] PCI: dwc: Move forward the iATU detection process
Date: Tue, 30 Mar 2021 09:51:18 +0200 [thread overview]
Message-ID: <b777ab31-e0b9-bbc0-9631-72b93097919e@samsung.com> (raw)
In-Reply-To: <5a4a7177-f8e1-6c8b-7c8a-8f5831de8455@samsung.com>
On 26.03.2021 18:05, Marek Szyprowski wrote:
> On 25.03.2021 21:19, Bjorn Helgaas wrote:
>> On Thu, Mar 25, 2021 at 10:24:28AM +0100, Marek Szyprowski wrote:
>>> On 25.01.2021 05:48, Zhiqiang Hou wrote:
>>>> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>>>>
>>>> In the dw_pcie_ep_init(), it depends on the detected iATU region
>>>> numbers to allocate the in/outbound window management bit map.
>>>> It fails after the commit 281f1f99cf3a ("PCI: dwc: Detect number
>>>> of iATU windows").
>>>>
>>>> So this patch move the iATU region detection into a new function,
>>>> move forward the detection to the very beginning of functions
>>>> dw_pcie_host_init() and dw_pcie_ep_init(). And also remove it
>>>> from the dw_pcie_setup(), since it's more like a software
>>>> perspective initialization step than hardware setup.
>>>>
>>>> Fixes: 281f1f99cf3a ("PCI: dwc: Detect number of iATU windows")
>>>> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>>> This patch causes exynos-pcie to hang during the initialization. It
>>> looks that some resources are not enabled yet, so calling
>>> dw_pcie_iatu_detect() much earlier causes a hang. When I have some
>>> time,
>>> I will try to identify what is needed to call it properly.
>> Thanks, I dropped it for now. We can add it back after we figure out
>> what the exynos issue is.
> Thanks, I will try to identify at which point of initialization it is
> safe to call iATU region detection.
I've just checked and it is enough to move the
dw_pcie_iatu_detect(pci);
after
pp->ops->host_init(pp);
in dw_pcie_host_init() to fix driver operation on Exynos SoCs with the
$subject patch applied.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
prev parent reply other threads:[~2021-03-30 7:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 4:48 [PATCH] PCI: dwc: Move forward the iATU detection process Zhiqiang Hou
2021-01-26 5:25 ` Kunihiko Hayashi
2021-01-27 6:27 ` Z.q. Hou
2021-01-28 0:19 ` Kunihiko Hayashi
2021-03-05 16:18 ` Rob Herring
2021-03-22 18:03 ` Lorenzo Pieralisi
2021-03-22 18:09 ` Lorenzo Pieralisi
2021-03-22 18:10 ` Bjorn Helgaas
[not found] ` <CGME20210325092429eucas1p25e95dd1920f2a1c9f808c72d10d1952d@eucas1p2.samsung.com>
2021-03-25 9:24 ` Marek Szyprowski
2021-03-25 20:19 ` Bjorn Helgaas
2021-03-26 17:05 ` Marek Szyprowski
2021-03-30 7:51 ` Marek Szyprowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b777ab31-e0b9-bbc0-9631-72b93097919e@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=Zhiqiang.Hou@nxp.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=helgaas@kernel.org \
--cc=jh80.chung@samsung.com \
--cc=jingoohan1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).