From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Xuefeng Li <lixuefeng@loongson.cn>,
Huacai Chen <chenhc@lemote.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>
Subject: Re: [RFC PATCH] PCI/portdrv: No need to call pci_disable_device() during shutdown
Date: Fri, 11 Sep 2020 09:54:40 +0800 [thread overview]
Message-ID: <b8f0d64d-8a29-aa4f-c764-397e87527600@loongson.cn> (raw)
In-Reply-To: <20200910202106.GA811000@bjorn-Precision-5520>
On 09/11/2020 04:21 AM, Bjorn Helgaas wrote:
> [+cc Huacai]
>
> On Thu, Sep 10, 2020 at 02:41:39PM -0500, Bjorn Helgaas wrote:
>> On Sat, Sep 05, 2020 at 04:33:26PM +0800, Tiezhu Yang wrote:
>>> After commit 745be2e700cd ("PCIe: portdrv: call pci_disable_device
>>> during remove") and commit cc27b735ad3a ("PCI/portdrv: Turn off PCIe
>>> services during shutdown"), it also calls pci_disable_device() during
>>> shutdown, this seems unnecessary, so just remove it.
>> I would like to get rid of the portdrv completely by folding its
>> functionality into the PCI core itself, so there would be no portdrv
>> probe or remove.
>>
>> Does this solve a problem?
Yes, sometimes it can not shutdown or reboot normally with
pci_disable_device().
>> If not, I'm inclined to just leave it
>> as-is for now. But if it fixes something, we should do the fix, of
>> course.
> This looks awfully similar to [1], so I guess we *do* need to do
> something here. I'll respond there since it has more details.
>
> [1] https://lore.kernel.org/r/1596268180-9114-1-git-send-email-chenhc@lemote.com
>
>>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>>> ---
>>> drivers/pci/pcie/portdrv_core.c | 1 -
>>> drivers/pci/pcie/portdrv_pci.c | 14 +++++++++++++-
>>> 2 files changed, 13 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c
>>> index 50a9522..1991aca 100644
>>> --- a/drivers/pci/pcie/portdrv_core.c
>>> +++ b/drivers/pci/pcie/portdrv_core.c
>>> @@ -491,7 +491,6 @@ void pcie_port_device_remove(struct pci_dev *dev)
>>> {
>>> device_for_each_child(&dev->dev, NULL, remove_iter);
>>> pci_free_irq_vectors(dev);
>>> - pci_disable_device(dev);
>>> }
>>>
>>> /**
>>> diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
>>> index 3a3ce40..cab37a8 100644
>>> --- a/drivers/pci/pcie/portdrv_pci.c
>>> +++ b/drivers/pci/pcie/portdrv_pci.c
>>> @@ -143,6 +143,18 @@ static void pcie_portdrv_remove(struct pci_dev *dev)
>>> }
>>>
>>> pcie_port_device_remove(dev);
>>> + pci_disable_device(dev);
>>> +}
>>> +
>>> +static void pcie_portdrv_shutdown(struct pci_dev *dev)
>>> +{
>>> + if (pci_bridge_d3_possible(dev)) {
>>> + pm_runtime_forbid(&dev->dev);
>>> + pm_runtime_get_noresume(&dev->dev);
>>> + pm_runtime_dont_use_autosuspend(&dev->dev);
>>> + }
>>> +
>>> + pcie_port_device_remove(dev);
>>> }
>>>
>>> static pci_ers_result_t pcie_portdrv_error_detected(struct pci_dev *dev,
>>> @@ -211,7 +223,7 @@ static struct pci_driver pcie_portdriver = {
>>>
>>> .probe = pcie_portdrv_probe,
>>> .remove = pcie_portdrv_remove,
>>> - .shutdown = pcie_portdrv_remove,
>>> + .shutdown = pcie_portdrv_shutdown,
>>>
>>> .err_handler = &pcie_portdrv_err_handler,
>>>
>>> --
>>> 2.1.0
>>>
next prev parent reply other threads:[~2020-09-11 1:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-05 8:33 [RFC PATCH] PCI/portdrv: No need to call pci_disable_device() during shutdown Tiezhu Yang
2020-09-10 19:41 ` Bjorn Helgaas
2020-09-10 20:21 ` Bjorn Helgaas
2020-09-11 1:54 ` Tiezhu Yang [this message]
2020-09-11 2:35 ` Oliver O'Halloran
2020-09-11 3:19 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8f0d64d-8a29-aa4f-c764-397e87527600@loongson.cn \
--to=yangtiezhu@loongson.cn \
--cc=bhelgaas@google.com \
--cc=chenhc@lemote.com \
--cc=helgaas@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).